Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed update of dataset page on sibling site instances. #337

Merged
merged 1 commit into from
Jul 9, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lab/lab.js
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ app.post("/api/v1/projects", (req, res, next) => {
*/
app.put("/api/v1/datasets", upload.array("_files", 1), (req, res, next) => {
//console.log(`======app.put datasets ${req.get('Content-Type')}`)
//console.log(`======app.put datasets ${req.body._metadata}`)
//console.log(`app.put datasets ${req.body._metadata}`);

// Parse request
if (req.body._metadata === undefined) {
Expand Down Expand Up @@ -398,7 +398,9 @@ app.put("/api/v1/datasets", upload.array("_files", 1), (req, res, next) => {
stageDatasetFile(req.files[0])
.then((file_id) => {return registerDataset(file_id, prediction_type, dependent_col, categorical_features, ordinal_features, metadata)})
.then((dataset_id) => {
//console.log(`==added file, dataset_id: ${dataset_id}==`)
//Pass the new dataset id to event emitter
req.params = { ...req.params, dataset_id: dataset_id };
emitEvent('datasetAdded', req);
res.send({
message: "Files uploaded",
dataset_id: dataset_id
Expand Down
16 changes: 11 additions & 5 deletions lab/socketServer.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,19 +55,18 @@ function emitEvent(event, req) {
return rp(FGLAB_URL + "/api/datasets")
.then(datasets => {
datasets.forEach(dataset =>
//sockets.forEach(socket => socket.emit('updateDataset', dataset))
sockets.forEach(socket => socket.emit('updateAIToggle', dataset._id, dataset.ai))
)
})
.catch((err) => {console.log(`Error: ${err}`)}); // Ignore failures

case 'aiToggled':
console.log(`=socketServer:aiToggled(${req.params.id})`)
//console.log(`=socketServer:aiToggled(${req.params.id})`)
return sockets.forEach(socket =>
socket.emit('updateAIToggle', JSON.stringify({ _id: req.params.id, nextAIState: req.body.ai }))
);
case 'recommenderStatusUpdated':
console.log(`=socketServer:recommenderStatusUpdated(${req.body.status})`)
//console.log(`=socketServer:recommenderStatusUpdated(${req.body.status})`)
return sockets.forEach(socket =>
socket.emit('updateRecommender', JSON.stringify({recommenderStatus: req.body.status }))
);
Expand All @@ -84,6 +83,7 @@ function emitEvent(event, req) {
})
.catch((err) => {console.log(`Error: ${err}`)}); // Ignore failures
case 'expUpdated':
//console.log("==== socketServer - case expUpdated");
return rp(FGLAB_URL + "/api/userexperiments/" + req.params.id)
.then(experiment => {
sockets.forEach(socket => socket.emit('updateExperiment', experiment));
Expand All @@ -95,11 +95,17 @@ function emitEvent(event, req) {
.catch((err) => {console.log(`Error: ${err}`)}); // Ignore failures
})
.catch((err) => {console.log(`Error: ${err}`)}); // Ignore failures
case 'datasetAdded':
//console.log(`* emitEvent - datasetAdded ${req.params.dataset_id}`);
return rp(FGLAB_URL + "/api/userdatasets/" + req.params.dataset_id)
.then(dataset => {
sockets.forEach(socket => socket.emit('addDataset', dataset));
})
.catch((err) => {console.log(`socketServer.emitEvent addDataset Error: ${err}`)}); // Ignore failures
}
}

module.exports = {
socketServer: socketServer,
emitEvent: emitEvent
};

};
10 changes: 8 additions & 2 deletions lab/webapp/src/config/configSocket.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,10 @@ along with this program. If not, see <https://www.gnu.org/licenses/>.

*/
import io from 'socket.io-client';
import { updateAI, updateDataset } from 'data/datasets/dataset/actions';
import { updateAI, updateDataset, addDataset } from 'data/datasets/dataset/actions';
import { addExperiment, updateExperiment } from 'data/experiments/actions';
import { fetchRecommender} from 'data/recommender/actions';
import { fetchDatasets } from 'data/datasets/actions';

let socket = io(`${location.protocol}//${location.hostname}:${location.port}`);
/**
Expand All @@ -43,7 +44,12 @@ const configSocket = (store) => {

socket.on('updateDataset', data => {
const dataset = JSON.parse(data)[0];
store.dispatch(updateDataset(dataset));
store.dispatch(updateDataset(dataset));
});

socket.on('addDataset', data => {
const dataset = JSON.parse(data)[0];
store.dispatch(addDataset(dataset));
});

socket.on('updateExperiment', data => {
Expand Down
2 changes: 1 addition & 1 deletion lab/webapp/src/data/datasets/api.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ require('es6-promise').polyfill();
import fetch from 'isomorphic-fetch';

export const fetchDatasets = () =>
fetch('/api/userdatasets')
fetch('/api/userdatasets') //See lab\webapp\src\data\datasets\dataset\api.js
.then(response => {
if(response.status >= 400) {
throw new Error(`${response.status}: ${response.statusText}`);
Expand Down
6 changes: 6 additions & 0 deletions lab/webapp/src/data/datasets/dataset/actions.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ export const TOGGLE_AI_SUCCESS = 'TOGGLE_AI_SUCCESS';
export const TOGGLE_AI_FAILURE = 'TOGGLE_AI_FAILURE';
export const AI_UPDATE = 'AI_UPDATE';
export const DATASET_UPDATE = 'DATASET_UPDATE';
export const DATASET_ADD = 'DATASET_ADD';
export const UPLOAD_DATASET_REQUEST = 'UPLOAD_DATASET_REQUEST';
export const UPLOAD_DATASET_SUCCESS = 'UPLOAD_DATASET_SUCCESS';
export const UPLOAD_DATASET_FAILURE = 'UPLOAD_DATASET_FAILURE';
Expand Down Expand Up @@ -100,3 +101,8 @@ export const updateDataset = (dataset) => ({
type: DATASET_UPDATE,
dataset
});

export const addDataset = (dataset) => ({
type: DATASET_ADD,
dataset
})
17 changes: 17 additions & 0 deletions lab/webapp/src/data/datasets/dataset/actions.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,23 @@ describe('testing how some UI action affects redux action stuff', () => {
expect(actionStuff.updateDataset(testDataset))
.toEqual(expectedAction);
})

it('addDataset', () => {
const testDataset = {
id: 'da_data',
info: {
experiment: 'pass',
result: [3,4,5]
}
};
const expectedAction = {
type: actionStuff.DATASET_ADD,
dataset: testDataset
};
expect(actionStuff.addDataset(testDataset))
.toEqual(expectedAction);
})

})

import * as apiTestHelper from './__mocks__/api';
Expand Down
7 changes: 7 additions & 0 deletions lab/webapp/src/data/datasets/dataset/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,17 @@ import {
TOGGLE_AI_FAILURE,
AI_UPDATE,
DATASET_UPDATE,
DATASET_ADD,
UPLOAD_DATASET_REQUEST,
UPLOAD_DATASET_SUCCESS,
UPLOAD_DATASET_FAILURE
} from './actions';

/***
NOTE - this isn't a reducer itself. It's called by the reducer datasets.byId, and
this is why it has the params 'state' and 'action'.
So don't be confused like I was! HTH
***/
const dataset = (state = {}, action) => {
switch(action.type) {
case TOGGLE_AI_REQUEST:
Expand All @@ -57,6 +63,7 @@ const dataset = (state = {}, action) => {
ai: action.nextAIState
});
case DATASET_UPDATE:
case DATASET_ADD:
return action.dataset;
case UPLOAD_DATASET_REQUEST:
//window.console.log('UPLOAD_DATASET_REQUEST action', action);
Expand Down
12 changes: 9 additions & 3 deletions lab/webapp/src/data/datasets/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ import {
TOGGLE_AI_FAILURE,
AI_UPDATE,
DATASET_UPDATE,
DATASET_ADD,
UPLOAD_DATASET_REQUEST,
UPLOAD_DATASET_SUCCESS,
UPLOAD_DATASET_FAILURE
Expand All @@ -52,6 +53,7 @@ const byId = (state = {}, action) => {
return map;
}, {});
case DATASET_UPDATE:
case DATASET_ADD:
return Object.assign({}, state, {
[action.dataset._id]: dataset(state[action.dataset._id], action)
});
Expand Down Expand Up @@ -90,6 +92,9 @@ const allIds = (state = [], action) => {
switch(action.type) {
case FETCH_DATASETS_SUCCESS:
return action.payload.map(d => d._id);
case DATASET_ADD:
//Adding a new dataset
return [...state, action.dataset._id];
default:
return state;
}
Expand Down Expand Up @@ -128,14 +133,15 @@ const getAllIds = (state) => state.datasets.allIds;
const getById = (state) => state.datasets.byId;
export const getSortedDatasets = createSelector(
[getAllIds, getById],
(allIds, byId) =>
allIds
(allIds, byId) => {
return allIds
.map(id => byId[id])
.sort((a, b) => {
const A = a.name.toLowerCase();
const B = b.name.toLowerCase();
return A > B ? 1 : A < B ? -1 : 0;
})
});
}
);

export default datasets;
2 changes: 2 additions & 0 deletions lab/webapp/src/data/experiments/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ const experiments = combineReducers({

export default experiments;

// Selectors //

const getExperiments = (state) => state.experiments;
const getQuery = (state, props) => props.location.query;
export const getFilters = createSelector(
Expand Down