Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit regress #593

Merged
merged 3 commits into from
Aug 5, 2023
Merged

Unit regress #593

merged 3 commits into from
Aug 5, 2023

Conversation

jay-m-dev
Copy link
Contributor

Removed deprecated presort parameter from pmlb_regression_results-small.tsv. this was removed from sklearn version 0.24 as documented here: https://scikit-learn.org/0.23/modules/generated/sklearn.ensemble.GradientBoostingRegressor.html?highlight=gradientboostingregressor#sklearn.ensemble.GradientBoostingRegressor

@jay-m-dev jay-m-dev added the bug label Aug 4, 2023
@jay-m-dev jay-m-dev requested a review from HyunjunA August 4, 2023 23:20
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5766817516

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on unit_regress at 82.102%

Totals Coverage Status
Change from base Build 5755599525: 82.1%
Covered Lines: 4335
Relevant Lines: 5280

💛 - Coveralls

@HyunjunA HyunjunA merged commit 6ce4a66 into master Aug 5, 2023
6 checks passed
@HyunjunA
Copy link
Contributor

HyunjunA commented Aug 5, 2023

I tested the unit_regress function for both classification and regression tasks on my Mac with an Apple M1 Max chip, and it worked properly. Jay also checked it on an arm64 virtual machine, and it functioned as expected.

@jay-m-dev jay-m-dev deleted the unit_regress branch August 8, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants