Add MDR utilities module and improve MDR model code #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was not accessing the dictionary values correctly.
Wasn’t using the correctly class labels variable.
Since predict and transform essentially do the same thing in MDR but return the data in a different shape, transform now calls predict and reshapes the data resulting from predict. This change reduces repeated code.
Because we reworked the default states of the MDR internal variables, this change needs to be reflected in the unit tests.
These unit tests ensure that MDR works as a feature transformer within sklearn pipelines, as well as with sklearn’s `cross_val_score` function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.