Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import assert_array_almost_equal from numpy instead of sklearn #1161

Merged
merged 3 commits into from
Jan 7, 2021

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Jan 6, 2021

What does this PR do?

Avoids the (now private) sklearn.utils._testing import assert_array_almost_equal, just pulling it from numpy (which it's always done)

Where should the reviewer start?

Run tests against sklearn >=0.22

How should this PR be tested?

Run tests against sklearn >=0.22

Any background context you want to provide?

Building downstream on conda-forge/tpot-feedstock#33

What are the relevant issues?

n/a (sry, didn't look)

Screenshots (if appropriate)

n/a

Questions:

  • Do the docs need to be updated?
    • no
  • Does this PR add new (Python) dependencies?
    • no

@bollwyvl bollwyvl changed the title guard import of assert_array_almost_equal import assert_array_almost_equal from numpy instead of sklearn Jan 6, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.677% when pulling f076653 on bollwyvl:patch-1 into 6448bdb on EpistasisLab:master.

@weixuanfu
Copy link
Contributor

Thank you for this PR. I will merge it to dev branch first.

@weixuanfu weixuanfu changed the base branch from master to development January 7, 2021 14:00
@weixuanfu weixuanfu merged commit 9d25033 into EpistasisLab:development Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants