Add command lines orion db dump and orion db load
#1005
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move dump logic into a function.
- Raise DatabaseError when error occurs in the script - If found many experiments for a given name, pick experiment with lower version
- raise DatabaseError when errors occur in th script - If found many experiments for a given name, pick experiment with lower version
notoraptor
changed the title
orion db dump and orion db loadorion db dump and orion db load
bouthilx
reviewed
Nov 23, 2022
|
|
||
| cli.get_basic_args_group(dump_parser) | ||
|
|
||
| dump_parser.add_argument( |
There was a problem hiding this comment.
We should add a --force option and avoid overwritting the output file if it already exists and --force is not passed.
bouthilx
reviewed
Nov 23, 2022
|
|
||
| def dump_database(orig_db, dump_host, experiment=None, version=None): | ||
| """Dump a database | ||
| :param orig_db: database to dump |
There was a problem hiding this comment.
We try to uniformise all docstrings to numpy format.
bouthilx
reviewed
Jan 13, 2023
bouthilx
reviewed
Jan 13, 2023
bouthilx
reviewed
Jan 17, 2023
| "-r", | ||
| "--resolve", | ||
| type=str, | ||
| choices=("ignore", "overwrite", "bump"), |
There was a problem hiding this comment.
I don't remember, did we discuss about making one choice the default one? Is it that if we don't specify one it will be prompted if needed?
Co-authored-by: Xavier Bouthillier <xavier.bouthillier@gmail.com>
Co-authored-by: Xavier Bouthillier <xavier.bouthillier@gmail.com>
|
Closed, continued here: #1082 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi @bouthilx ! This is a PR to fix #953 . Commands
orion db dumpandorion db loadare added.orion db dumpshow already fully workorion db loadshould work with parameter--exp, and for full import if there is no ID collision.TODO
orion db loadwork when there is ID collision on full import.Changes
Add commands
orion db dumpandorion db loadChecklist
Tests
$ tox -e py38; replace38by your Python version if necessary)Documentation
Quality
$ tox -e lint)