Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display trial status in trials table on dashboard #1071

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Display trial status in trials table on dashboard #1071

merged 2 commits into from
Jan 23, 2023

Conversation

notoraptor
Copy link
Collaborator

Description

Hi @bouthilx ! This is a small PR to display trial status in trials table on dashboard.

Changes

There was already a merged commit to make web API entry point /trials/{experiment_name}/{trial_id} return trial status: 3b3fabf

So, we just need to edit only dashboard to display trial status there.

Checklist

Tests

  • I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
  • All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

  • I have updated the relevant documentation related to my changes

Quality

  • I have read the CONTRIBUTING doc
  • My commits messages follow this format
  • My code follows the style guidelines ($ tox -e lint)

bouthilx
bouthilx approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@bouthilx bouthilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@notoraptor notoraptor merged commit 2f7eb37 into Epistimio:develop Jan 23, 2023
@notoraptor notoraptor deleted the display-trial-status branch January 23, 2023 17:21
@notoraptor notoraptor mentioned this pull request Mar 2, 2023
Merged
@notoraptor notoraptor added dashboard feature Introduces a new feature labels Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouthilx bouthilx bouthilx approved these changes

Assignees
No one assigned
Labels
dashboard feature Introduces a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notoraptor @bouthilx