Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - fix pre-commit and backward compatibility #1079

Conversation

notoraptor
Copy link
Collaborator

Description

Hi @bouthilx ! This is a small PR to fix unit tests related to pre-commit and backward compatibility.

Changes

  • Bump isort version
  • Remove old orion versions (up to 0.1.12) from backward compatibility tests

Checklist

Tests

  • I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
  • All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

  • I have updated the relevant documentation related to my changes

Quality

  • I have read the CONTRIBUTING doc
  • My commits messages follow this format
  • My code follows the style guidelines ($ tox -e lint)

…ip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'`

- Try to solve by bumping isort version: home-assistant/core#86892 (comment)
…versions from 0.1.13

Trying to fix compatibility error occuring in versions 0.1.9 to 0.1.12 with error:
```
  pkg_resources.extern.packaging._tokenizer.ParserSyntaxError: Expected closing RIGHT_PARENTHESIS
      pytest (>=3.0.0scikit-learn) ; extra == 'test'
```
Copy link
Member

@bouthilx bouthilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bouthilx bouthilx merged commit 70aae93 into Epistimio:develop Feb 2, 2023
@notoraptor notoraptor deleted the ci-fix-pre-commit-and-backward-compatibility branch February 2, 2023 20:17
@notoraptor notoraptor mentioned this pull request Mar 2, 2023
@notoraptor notoraptor added the bug Indicates an unexpected problem or unintended behavior label Mar 2, 2023
@bouthilx bouthilx added ci and removed bug Indicates an unexpected problem or unintended behavior labels Mar 2, 2023
@notoraptor notoraptor added the bug Indicates an unexpected problem or unintended behavior label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants