Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Added trial count to delete_trials message #656

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

mgermain
Copy link

@mgermain mgermain commented Sep 7, 2021

Minimal edit to fix #653, I also tried to stick to the recommendation in the issue.

There are much better ways to do this. but that would require a deeper dive into the code.

What do you suggest?

@bouthilx
Copy link
Member

bouthilx commented Sep 8, 2021

Good enough! We can optimize this latter on if needed. Could you please do it as well for delete_experiments and add a test for each? Tests would be here. You can simply verify if the correct number of trials is printed using capsys (doc here).

Co-authored-by: Xavier Bouthillier <xavier.bouthillier@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add match count to user prompt in DB commands
2 participants