Fixing some details for the tutorials to run. #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ain__' so that it doesnt crash
bouthilx
reviewed
Sep 8, 2022
| @@ -52,13 +52,13 @@ | |||
| # a ``ValueError`` will be raised. At least one of the results must have the type ``objective``, | |||
| # the metric that is minimized by the algorithm. | |||
|
|
|||
| if __name__ == '__main__': | |||
There was a problem hiding this comment.
This one is part of the sphink-gallery, which automatically convert the script into a sphinx page and a jupiter notebook. Maybe there could be a warning for macos user to try it using the jupiter notebook or encapsulating the code in a main function and running under if __name__ == '__main__'.
bouthilx
reviewed
Sep 8, 2022
| @@ -259,8 +259,8 @@ def main( | |||
| #%% | |||
| # You can test the training pipeline before working with the hyperparameter optimization. | |||
|
|
|||
|
|
|||
| main(epochs=4) | |||
| if __name__ == '__main__': | |||
|
Thanks for the fixes! There is an issue with black formatting. You can look at black plugins in vscode to automatically format your code otherwise you can use the pre-commit hook as documented here: https://orion.readthedocs.io/en/latest/developer/ci.html. |
bouthilx
approved these changes
Sep 23, 2022
bouthilx
added
the
documentation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While doing the tutorials, some code wasn't running properly. This PR is basically to fix that.
Changes
Adding some imports to the tutorial for scikit,
Fixing a small argument mistake for pytorch,
adding if name == 'main': in python script so that they dont crash on macos.
Tests
$ tox -e py38; replace38by your Python version if necessary)Documentation
Quality
$ tox -e lint)