-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(events): Add event context #213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipecsl
commented
Feb 3, 2025
petzel
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the super quick turnaround here! Overall looks great, but we should also add size/length checks. Feel free to add that in a follow up PR or update this one (in which case just tag me and I'll review again).
PTAL @petzel for re-review 🙏🏽 |
petzel
reviewed
Feb 6, 2025
petzel
reviewed
Feb 6, 2025
petzel
approved these changes
Feb 6, 2025
Co-authored-by: Eric Petzel <epetzel@gmail.com>
Co-authored-by: Eric Petzel <epetzel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels: mergeable
Fixes: FF-3932
Motivation and Context
Allow attaching
context
keys and values with events dispatched through the Track API.Description
Context are optional "global" key/value pairs associated with all events and delivered with the Track API to the ingestion endpoint.
How has this been tested?
Wrote tests