Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(events): Add event context #213

Merged
merged 8 commits into from
Feb 6, 2025
Merged

feat(events): Add event context #213

merged 8 commits into from
Feb 6, 2025

Conversation

felipecsl
Copy link
Member


labels: mergeable

Fixes: FF-3932

Motivation and Context

Allow attaching context keys and values with events dispatched through the Track API.

Description

Context are optional "global" key/value pairs associated with all events and delivered with the Track API to the ingestion endpoint.

How has this been tested?

Wrote tests

Copy link
Contributor

@petzel petzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the super quick turnaround here! Overall looks great, but we should also add size/length checks. Feel free to add that in a follow up PR or update this one (in which case just tag me and I'll review again).

src/events/default-event-dispatcher.spec.ts Outdated Show resolved Hide resolved
src/events/default-event-dispatcher.ts Show resolved Hide resolved
src/events/event-dispatcher.ts Show resolved Hide resolved
@felipecsl felipecsl requested a review from petzel February 4, 2025 22:11
@felipecsl
Copy link
Member Author

PTAL @petzel for re-review 🙏🏽

felipecsl and others added 2 commits February 5, 2025 19:03
Co-authored-by: Eric Petzel <epetzel@gmail.com>
Co-authored-by: Eric Petzel <epetzel@gmail.com>
@felipecsl felipecsl merged commit f6c3d4f into main Feb 6, 2025
8 checks passed
@felipecsl felipecsl deleted the ff-3932-context branch February 6, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants