Ability to set configuration request parameters on an already instantiated client instance #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoromanovsky
approved these changes
Feb 3, 2024
Comment on lines
+1183
to
+1185
| await client.fetchFlagConfigurations(); | ||
| variation = client.getAssignment(subjectForGreenVariation, flagKey); | ||
| expect(variation).toBe('green'); |
sameerank
approved these changes
Feb 3, 2024
src/client/eppo-client.ts
Outdated
| throw new Error( | ||
| 'Eppo SDK unable to fetch flag configurations without a request configuration', | ||
| 'Eppo SDK unable to fetch flag configurations without a configuration request parameters', |
There was a problem hiding this comment.
Parameters is plural so "Eppo SDK unable to fetch flag configurations without a configuration request parameters"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Ticket: (Eppo Internal) FF-1557 - JS Client SDK should return null when not initialized
👯 Related PR:
eppo-client-sdk#48Motivation and Context
Using
EppoRandomizationProviderwithoutwaitForInitialization = trueor any other JavaScript pattern where initialization of the client is notawaited, could result in somegetInstance()andgetAssignment()calls on an uninitialized instance.Previous changes to
js-client-sdkmade it so that it threw an error (link). However, we want to revert to the behavior of returningnull,which this PR does (but now with a warning) on calls togetAssignment().To accomplish this, we need to revert to having a default initialized instance (link to where that was changed) that is later populated during initialization.
Description
To allow upstream-created client instances to set configuration request parameters, we provide a new method:
setConfigurationRequestParameters().I also renamed the internal variables to
configurationRequestParametersto more consistent and not have "config" in them twice.How has this been tested?
eppo-client.spec.tsjs-client-sdkandnode-server-sdkrepositories usingmake prepareandyarn add --force --file:../js-client-sdk-common