Use commons 3.0.6; MemoryOnlyConfigurationStore without LRU (#59)

Eppo-exp · May 16, 2024 · 9a34f5e · 9a34f5e
1 parent c123eed
commit 9a34f5e
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 79 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@eppo/node-server-sdk",
-  "version": "3.0.1",
+  "version": "3.0.2",
   "description": "Eppo node server SDK",
   "main": "dist/index.js",
   "files": [
@@ -29,7 +29,7 @@
   },
   "homepage": "https://github.com/Eppo-exp/node-server-sdk#readme",
   "dependencies": {
-    "@eppo/js-client-sdk-common": "3.0.2",
+    "@eppo/js-client-sdk-common": "3.0.6",
     "lru-cache": "^10.0.1"
   },
   "devDependencies": {

diff --git a/src/configuration-store.spec.ts b/src/configuration-store.spec.ts
diff --git a/src/configuration-store.ts b/src/configuration-store.ts
diff --git a/src/constants.ts b/src/constants.ts
diff --git a/src/index.spec.ts b/src/index.spec.ts
@@ -175,15 +175,15 @@ describe('EppoClient E2E test', () => {
     });
 
     it('returns the default value when ufc config is absent', () => {
-      const mockConfigStore = td.object<IConfigurationStore>();
+      const mockConfigStore = td.object<IConfigurationStore<Flag>>();
       td.when(mockConfigStore.get(flagKey)).thenReturn(null);
       const client = new EppoClient(mockConfigStore, requestParamsStub);
       const assignment = client.getStringAssignment(flagKey, 'subject-10', {}, 'default-value');
       expect(assignment).toEqual('default-value');
     });
 
     it('logs variation assignment and experiment key', () => {
-      const mockConfigStore = td.object<IConfigurationStore>();
+      const mockConfigStore = td.object<IConfigurationStore<Flag>>();
       td.when(mockConfigStore.get(flagKey)).thenReturn(mockUfcFlagConfig);
       const subjectAttributes = { foo: 3 };
       const client = new EppoClient(mockConfigStore, requestParamsStub);
@@ -208,7 +208,7 @@ describe('EppoClient E2E test', () => {
     });
 
     it('handles logging exception', () => {
-      const mockConfigStore = td.object<IConfigurationStore>();
+      const mockConfigStore = td.object<IConfigurationStore<Flag>>();
       td.when(mockConfigStore.get(flagKey)).thenReturn(mockUfcFlagConfig);
       const subjectAttributes = { foo: 3 };
       const client = new EppoClient(mockConfigStore, requestParamsStub);

diff --git a/src/index.ts b/src/index.ts
@@ -4,12 +4,14 @@ import {
   EppoClient,
   IEppoClient,
   FlagConfigurationRequestParameters,
+  MemoryOnlyConfigurationStore,
+  Flag,
 } from '@eppo/js-client-sdk-common';
+import { ObfuscatedFlag } from '@eppo/js-client-sdk-common/dist/interfaces';
 
-import { InMemoryConfigurationStore } from './configuration-store';
-import { MAX_CACHE_ENTRIES } from './constants';
 import { sdkName, sdkVersion } from './sdk-data';
 
+
 /**
  * Configuration used for initializing the Eppo client
  * @public
@@ -74,7 +76,7 @@ let clientInstance: IEppoClient;
  */
 export async function init(config: IClientConfig): Promise<IEppoClient> {
   validation.validateNotBlank(config.apiKey, 'API key required');
-  const configurationStore = new InMemoryConfigurationStore(MAX_CACHE_ENTRIES);
+  const configurationStore = new MemoryOnlyConfigurationStore<Flag | ObfuscatedFlag>();
 
   const requestConfiguration: FlagConfigurationRequestParameters = {
     apiKey: config.apiKey,

diff --git a/yarn.lock b/yarn.lock
@@ -460,10 +460,10 @@
   resolved "https://registry.npmjs.org/@bcoe/v8-coverage/-/v8-coverage-0.2.3.tgz"
   integrity sha512-0hYQ8SB4Db5zvZB4axdMHGwEaQjkZzFjQiN9LVYvIFB2nSUHW9tYpxWriPrWDASIxiaXax83REcLxuSdnGPZtw==
 
-"@eppo/js-client-sdk-common@3.0.2":
-  version "3.0.2"
-  resolved "https://registry.yarnpkg.com/@eppo/js-client-sdk-common/-/js-client-sdk-common-3.0.2.tgz#c1929fcad1b67676657d721cdc37561da108565d"
-  integrity sha512-Px7ppXMiWSNYYBRWORLcPSnOSreZASYzvn58CD1ZmKXDIruEOMD/39OUttDHex+tIj26f/BsVZNJzkR4zaD4Lg==
+"@eppo/js-client-sdk-common@3.0.6":
+  version "3.0.6"
+  resolved "https://registry.yarnpkg.com/@eppo/js-client-sdk-common/-/js-client-sdk-common-3.0.6.tgz#8d2019d45708b944e26e493f09bcce833925ffa1"
+  integrity sha512-YV32rf2UjNuKDAwyEl2HKearxsHRr2UDOJl+xblq5RCG8KB19xjxlNoUeFHd6FwTmqDVFF998r2DDEzoL496YQ==
   dependencies:
     md5 "^2.3.0"
     pino "^8.19.0"