Remove deprecated test classes (pantsbuild#7243)

### Problem `BaseTest` and the v1-aware `TaskTestBase` are long deprecated. Additionally, the `GraphTest` classes used v2 APIs that existed before `TestBase` came around. ### Solution Delete deprecated classes, and port `GraphTest` to `TestBase`.
Eric-Arellano · Feb 14, 2019 · bc0536c · bc0536c
1 parent e4456fd
commit bc0536c
Show file tree

Hide file tree

Showing 22 changed files with 52 additions and 1,021 deletions.
diff --git a/testprojects/src/resources/org/pantsbuild/testproject/buildfile_path/BUILD b/testprojects/src/resources/org/pantsbuild/testproject/buildfile_path/BUILD
@@ -1,6 +1,3 @@
 target(
-  dependencies=[
-    'testprojects/src/resources/org/pantsbuild/testproject/ordering:literal'
-  ],
   description='''This target exists at path {}.'''.format(buildfile_path()),
 )
diff --git a/testprojects/src/resources/org/pantsbuild/testproject/ordering/BUILD b/testprojects/src/resources/org/pantsbuild/testproject/ordering/BUILD
diff --git a/testprojects/src/resources/org/pantsbuild/testproject/ordering/a b/testprojects/src/resources/org/pantsbuild/testproject/ordering/a
diff --git a/testprojects/src/resources/org/pantsbuild/testproject/ordering/b b/testprojects/src/resources/org/pantsbuild/testproject/ordering/b
diff --git a/testprojects/src/resources/org/pantsbuild/testproject/ordering/d b/testprojects/src/resources/org/pantsbuild/testproject/ordering/d
diff --git a/testprojects/src/resources/org/pantsbuild/testproject/ordering/i b/testprojects/src/resources/org/pantsbuild/testproject/ordering/i
diff --git a/testprojects/src/resources/org/pantsbuild/testproject/ordering/l b/testprojects/src/resources/org/pantsbuild/testproject/ordering/l
diff --git a/testprojects/src/resources/org/pantsbuild/testproject/ordering/n b/testprojects/src/resources/org/pantsbuild/testproject/ordering/n
diff --git a/testprojects/src/resources/org/pantsbuild/testproject/ordering/p b/testprojects/src/resources/org/pantsbuild/testproject/ordering/p
diff --git a/testprojects/src/resources/org/pantsbuild/testproject/ordering/s b/testprojects/src/resources/org/pantsbuild/testproject/ordering/s
diff --git a/testprojects/src/resources/org/pantsbuild/testproject/ordering/t b/testprojects/src/resources/org/pantsbuild/testproject/ordering/t
diff --git a/testprojects/src/resources/org/pantsbuild/testproject/ordering/u b/testprojects/src/resources/org/pantsbuild/testproject/ordering/u
diff --git a/tests/python/pants_test/BUILD b/tests/python/pants_test/BUILD
@@ -5,7 +5,6 @@ python_library(
   name='test_infra',
   dependencies=[
     '3rdparty/python:future',
-    ':base_test',
     'tests/python/pants_test:int-test-for-export',
     'tests/python/pants_test:test_base',
     'tests/python/pants_test/jvm:jar_task_test_base',
@@ -24,28 +23,6 @@ python_library(
   )
 )
 
-python_library(
-  name = 'base_test',
-  sources = ['base_test.py'],
-  dependencies = [
-    '3rdparty/python:future',
-    'src/python/pants/base:build_file',
-    'src/python/pants/base:build_root',
-    'src/python/pants/base:cmd_line_spec_parser',
-    'src/python/pants/base:deprecated',
-    'src/python/pants/base:exceptions',
-    'src/python/pants/base:project_tree',
-    'src/python/pants/build_graph',
-    'src/python/pants/init',
-    'src/python/pants/source',
-    'src/python/pants/subsystem',
-    'src/python/pants/task',
-    'src/python/pants/util:dirutil',
-    'tests/python/pants_test/base:context_utils',
-    'tests/python/pants_test/option/util',
-  ]
-)
-
 python_library(
   name = 'int-test-for-export',
   sources = [
@@ -119,7 +96,7 @@ python_tests(
   name = 'test_maven_layout',
   sources = ['test_maven_layout.py'],
   dependencies = [
-    ':base_test',
+    ':test_base',
     'src/python/pants/backend/jvm/subsystems:junit',
     'src/python/pants/build_graph',
     'src/python/pants/source',

diff --git a/tests/python/pants_test/backend/python/tasks/BUILD b/tests/python/pants_test/backend/python/tasks/BUILD
@@ -54,7 +54,6 @@ python_tests(
     'tests/python/pants_test/backend/python/tasks/util',
     'tests/python/pants_test/engine:scheduler_test_base',
     'tests/python/pants_test/subsystem:subsystem_utils',
-    'tests/python/pants_test/tasks:task_test_base',
     'tests/python/pants_test:task_test_base',
   ],
   timeout=600

diff --git a/tests/python/pants_test/backend/python/tasks/native/BUILD b/tests/python/pants_test/backend/python/tasks/native/BUILD
@@ -33,7 +33,6 @@ python_tests(
     'tests/python/pants_test/backend/python/tasks/util',
     'tests/python/pants_test/engine:scheduler_test_base',
     'tests/python/pants_test/subsystem:subsystem_utils',
-    'tests/python/pants_test/tasks:task_test_base',
     'tests/python/pants_test:task_test_base',
   ],
   tags={'platform_specific_behavior'},