fixup! refactor: split handle validation into early pass in `Validato…

…r::validate` Resolves <gfx-rs#2090 (comment)>.
ErichDonGubler · Dec 16, 2022 · e1229f1 · e1229f1
1 parent 62f43a6
commit e1229f1
Showing 1 changed file with 16 additions and 2 deletions.
diff --git a/src/valid/handles.rs b/src/valid/handles.rs
@@ -278,8 +278,22 @@ impl super::Validator {
  .check_dep(image)?
  .check_dep(sampler)?
  .check_dep(coordinate)?
- .check_dep_opt(array_index)?
- .check_dep_opt(depth_ref)?;
+ .check_dep_opt(array_index)?;
+
+ match level {
+ crate::SampleLevel::Auto | crate::SampleLevel::Zero => (),
+ crate::SampleLevel::Exact(expr) => {
+ handle.check_dep(expr)?;
+ }
+ crate::SampleLevel::Bias(expr) => {
+ handle.check_dep(expr)?;
+ }
+ crate::SampleLevel::Gradient { x, y } => {
+ handle.check_dep(x)?.check_dep(y)?;
+ }
+ };
+
+ handle.check_dep_opt(depth_ref)?;
  }
  crate::Expression::ImageLoad {
  image,