Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding feature TLM router #24

Merged
merged 37 commits into from
Jul 21, 2024
Merged

Adding feature TLM router #24

merged 37 commits into from
Jul 21, 2024

Conversation

ErickOF
Copy link
Owner

@ErickOF ErickOF commented Jul 20, 2024 •
edited
Loading

New

  • Generalize the Initiator and the target into the router module.
  • Add Makefile to compile the router module.
  • Add edge detector (AT model), filter (PV model), and rgb2gray (PV model) modules into router compílation.
  • Add bash script to make easier runs.
  • Include memory for storing the data using TLM transactions.
  • Add a sanity check to ensure the image is written as expected in memory.
  • Add the unification module to the chain of transactions.
  • Add the compression block to the TLM testbench.
  • Use RGB noisy images in the testbench.

Fix

  • Clean up unused communication module.
  • Clean up unused code in the router module.

RMorales25 and others added 30 commits July 20, 2024 00:53
@RMorales25 @ErickOF
Fix/Generalize Initiator
92b18fd
@RMorales25 @ErickOF
Fix/Generalize Target
ed3b320
@RMorales25 @ErickOF
Add makefile and other needed files
1036999
@jgavillalobos @ErickOF
Fix compilation issue with missing file
1f37f25
@jgavillalobos @ErickOF
Copy work from communication module
a4c31a9
@jgavillalobos @ErickOF
Delete unrequired files
c9d2c1b
@jgavillalobos @ErickOF
Change folder for newer version of systemc
8a8db0e
@jgavillalobos @ErickOF
Update Makefile to use other folders for the reused blocks
7100a18
@jgavillalobos @ErickOF
Add new dbgprint function to show file and line from which a print is…
0ae2449 
… comming from
@jgavillalobos @ErickOF
Add bash script to make easier runs
575daf4
@jgavillalobos @ErickOF
Add RGB2GRAY module for testing with TLM
00982c7
@jgavillalobos @ErickOF
Use AT model of edge_detector instead of LT
a7013da
@jgavillalobos @ErickOF
Fix wrong values being writen in the jpg files
4090bfa
@jgavillalobos @ErickOF
Fix bad values assigning to resulting image
54e27de
@jgavillalobos @ErickOF
Change how the delays of initiator and target are used
b561085
@jgavillalobos @ErickOF
Use normal access to RGB2GRAY module instead of TLM
7df8821
@jgavillalobos @ErickOF
Include memory for storing the data using TLM transactions
ffc5b74 
Preload the image inside the memory and load it from there to use it for RGB2GRAY block, then save the results back into the memory, then load the results from there to use them in the edge detector block and then save the results from the gradients X and Y in the memory for a future use
@jgavillalobos @ErickOF
Remove unrequired local references
ddf95ad
@jgavillalobos @ErickOF
Add Filter block to TLM TB
8ca3cf7
@jgavillalobos @ErickOF
Add sanity check to ensure that the image is being written as expecte…
82877d0 
…d in memory
@jgavillalobos @ErickOF
Add unification module to the chain of transactions
89a7490
@RMorales25 @ErickOF
Add img_router and testbench
60b0970
@RMorales25 @ErickOF
Fix target to respond using a thread method
da9d700
@RMorales25 @ErickOF
Clean and fix initiator to not wait for write responses
a95d859
@RMorales25 @ErickOF
clean Here prints
12623bb
@RMorales25 @ErickOF
makefile and run_all for router tb
5c2dbc0
@jgavillalobos @ErickOF
Add compression block to TLM TB
ebd6ed1
@RMorales25 @ErickOF
Add router to global tb
8a315e7
@RMorales25 @ErickOF
Add transaction ID tracking
af1afba
@RMorales25 @ErickOF
Add transaction ID tracking
2607c75
@ErickOF ErickOF added the enhancement New feature or request label Jul 20, 2024
@ErickOF ErickOF added this to the project2 milestone Jul 20, 2024
@ErickOF ErickOF self-assigned this Jul 20, 2024
ErickOF
ErickOF commented Jul 20, 2024
View reviewed changes
modules/Makefile Show resolved Hide resolved
modules/Makefile Show resolved Hide resolved
modules/Makefile Show resolved Hide resolved
modules/Makefile Show resolved Hide resolved
modules/Makefile Show resolved Hide resolved
modules/router/src/tb_edge_detector_tlm.cpp Outdated Show resolved Hide resolved
modules/router/src/tb_edge_detector_tlm.cpp Outdated Show resolved Hide resolved
modules/router/src/tb_edge_detector_tlm.cpp Outdated Show resolved Hide resolved
tools/datagen/datagen.py Outdated Show resolved Hide resolved
tools/datagen/datagen.py Show resolved Hide resolved
ErickOF
ErickOF commented Jul 20, 2024
View reviewed changes
Copy link
Owner Author

@ErickOF ErickOF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second review

ErickOF
ErickOF commented Jul 21, 2024
View reviewed changes
Copy link
Owner Author

@ErickOF ErickOF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ErickOF ErickOF merged commit 094537e into dev Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ErickOF ErickOF

Labels
enhancement New feature or request
Projects
None yet
Milestone
project2
Development

Successfully merging this pull request may close these issues.
3 participants
@ErickOF @RMorales25 @jgavillalobos