This repository has been archived by the owner on Feb 5, 2023. It is now read-only.
Execute the callback that can be passed to the Builder #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: laravel/scout#111 Implementation analogical to the official AlgoliaEngine implementation: https://github.com/laravel/scout/blob/v3.0.3/src/Engines/AlgoliaEngine.php#L112-L119
kronthto
added a commit
to dieMAYREI/laravel-scout-elastic
that referenced
this pull request
May 16, 2017
|
It's been a while but no response yet. This is incredibly useful. Ping @ErickTamayo |
Closed
|
Sorry for the delay I'm really busy last months |
|
Thanks for merging. I cannot find the new version tag (3.0.6) on Packagist (https://packagist.org/packages/tamayo/laravel-scout-elastic) yet, could you please check that @ErickTamayo ? Either trigger the sync manually or set up the Packagist Service in the Github Repo? |
|
That's weird, let me try to refresh it |
|
Updated it, now is showing. |
sonnysantino
pushed a commit
to sonnysantino/laravel-scout-elastic
that referenced
this pull request
Jan 17, 2020
* Updating 0.0.1 (ErickTamayo#8) * fixing config key + updating the Usage on README (ErickTamayo#6) * Rename ElasticsearchEngineTets.php to ElasticsearchEngineTest.php (ErickTamayo#7) * Updating 0.0.1 (ErickTamayo#11) * fixing config key + updating the Usage on README (ErickTamayo#6) * Rename ElasticsearchEngineTets.php to ElasticsearchEngineTest.php (ErickTamayo#7) * Update ElasticsearchEngine.php (ErickTamayo#10) * Updating 0.0.1 (ErickTamayo#14) * fixing config key + updating the Usage on README (ErickTamayo#6) * Rename ElasticsearchEngineTets.php to ElasticsearchEngineTest.php (ErickTamayo#7) * Update ElasticsearchEngine.php (ErickTamayo#10) * optimized creation of params array for better performance when dealing with huge amount of models (ErickTamayo#13) * Make stable (ErickTamayo#18) (ErickTamayo#19) * Bumped Scout version to v2.0.x Bumped elasticsearch/elasticsearch to v5.0 * Bumped Scout version to 3.0 * Fix config name (ErickTamayo#35) * v3.0.2 bumping to php 5.6.6 (Earliest version that can support php elasticsearch) (ErickTamayo#48) `within` now is being taken into account when specified ErickTamayo#31 Now if the record is not found on the db will not throw undefined offset ErickTamayo#36 Implemented orderBy ErickTamayo#46 * Update ElasticsearchProvider.php (ErickTamayo#54) use `app` instead of `resolve` to make lumen 5.4 compatible. `app` and `resolve` are identical since 5.4, see https://github.com/laravel/framework/blob/5.4/src/Illuminate/Foundation/helpers.php#L690 * chain `values` method in `map` function (ErickTamayo#66) In ```php collect($results['hits']['hits'])->map(function ($hit) use ($model, $models) { return isset($models[$hit['_id']]) ? $models[$hit['_id']] : null; })->filter(); ``` would generate some holds which would cause `paginate` results objects rather than list. * Support for "WHERE IN" searches if array is passed to `where` (ErickTamayo#55) Right now passing an array results in: "illegal_state_exception: Can't get text on a START_ARRAY" Solution based on http://stackoverflow.com/a/40737488/7362396 * Execute the callback that can be passed to the Builder in performSearch (ErickTamayo#56) Context: laravel/scout#111 Implementation analogical to the official AlgoliaEngine implementation: https://github.com/laravel/scout/blob/v3.0.3/src/Engines/AlgoliaEngine.php#L112-L119 * Update ElasticsearchEngine.php (ErickTamayo#51) Predefine elastic variable. * Enable Laravel5.5 package Auto-Discovery (ErickTamayo#81) * Removed count function. Fixes ErickTamayo#80 (ErickTamayo#84) Since php 7.2, count a number will generate a warning. Because $results['hits']['total'] is a number we can just compare it to zero. `if ($results['hits']['total'] === 0)` * Allow installation with Scout 4 (ErickTamayo#99) * Compatibility with Scout 5 (ErickTamayo#106) * Compatibility with Scout 5 No "cross-installation" possible due to changed method signature Pass around new $builder var Also: Use getScoutModelsByIds/getScoutKey Inspired by laravel/scout@4.0...5.0#diff-f2faa85f27580a9b67d73a8a273bfef1 / laravel/scout@9f06b9c * Remove PHP5 as laravel/scout^5 / laravel5.6 also removed it * Added support for Laravel Scout 6.0 and 7.0, Laravel 5.8 (ErickTamayo#119) * Elasticsearch downgrade Co-authored-by: Erick Tamayo <ErickTamayo@users.noreply.github.com> Co-authored-by: Till Krüss <tillkruss@users.noreply.github.com> Co-authored-by: Joey <joey.xf@gmail.com> Co-authored-by: Tobias Kronthaler <kronthto@users.noreply.github.com> Co-authored-by: Nirav <nirav.t.prajapati21@gmail.com> Co-authored-by: Camilo <camilo.castro.cabrera@gmail.com> Co-authored-by: Semyon Chetvertnyh <semyon.chetvertnyh@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context/Reasoning: laravel/scout#111
Right now the callback you can pass is straight up ignored with this engine/driver.
This implementation is analogical to the official AlgoliaEngine implementation: https://github.com/laravel/scout/blob/v3.0.3/src/Engines/AlgoliaEngine.php#L112-L119