Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial LSP support #335

Merged
merged 3 commits into from
Oct 25, 2019
Merged

Initial LSP support #335

merged 3 commits into from
Oct 25, 2019

Conversation

mcserep
Copy link
Collaborator

@mcserep mcserep commented Jun 13, 2019

Added initial version of Language Server Protocol (LSP) support through LspServiceHandler (standard CodeCompass service) and LspHandler (secondary web request handler alongside ThriftHandler from now on).

Currently goto definition, find all references, retrieving diagram types and diagrams themselves are supported.

@mcserep
Added initial version of LSP support through LspServiceHandler (stand…
5ceb59f 
…ard CodeCompass service) and LspHandler (web request handler alongside ThriftHandler).

Currently goto definition, find all references, retrieving diagram types and diagrams themselves are supported.
@mcserep mcserep added Kind: Enhancement 🌟 Plugin: C++ Issues related to the parsing and presentation of C++ projects. labels Jun 13, 2019
@mcserep mcserep added this to the Support milestone Jun 13, 2019
@mcserep mcserep requested a review from bruntib June 13, 2019 08:09
@mcserep
Update ODB generated file include for LSP service with Ericsson#323.
0a0f585
@mcserep
Thrift is a dependency of LspService and LspHandler, as required by t…
9a47571 
…he included models. Therefore Thrift must be added to include and library path of the LSP service library and the webserver binary.
@mcserep
Copy link
Collaborator Author

mcserep commented Jun 18, 2019

CI passes now.

@mcserep mcserep changed the base branch from master to lsp October 25, 2019 23:20
@mcserep
Copy link
Collaborator Author

mcserep commented Oct 25, 2019

Merging the PR into a new lsp branch as discussed F2F. LSP related development will be merged there until a production-ready state is reached to be merged into master.

@mcserep mcserep merged commit 29dcf3c into Ericsson:lsp Oct 25, 2019
@mcserep mcserep deleted the lsp-service branch October 25, 2019 23:24
@mcserep mcserep added the Target: LSP Issues related to Language Server Protocol (LSP)-based operation, as opposed to the Web app. label Jan 8, 2023
@mcserep mcserep mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruntib bruntib Awaiting requested review from bruntib

Assignees
No one assigned
Labels
Kind: Enhancement 🌟 Plugin: C++ Issues related to the parsing and presentation of C++ projects. Target: LSP Issues related to Language Server Protocol (LSP)-based operation, as opposed to the Web app.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mcserep