Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade NodeJS and NPM for tarball build #624

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

mcserep
Copy link
Collaborator

@mcserep mcserep commented Aug 10, 2023

The new web GUI officially requires NodeJS v18+, while in the Ubuntu 16.04 based tarball build script we have NodeJS 14 installed, which fails.

Unfortunately NodeJS v18 is not compatible with Ubuntu 16.04. (GLIBC mismatch error.)
This PR upgrade NodeJS from v14 to v16 and NPM from v6 to v8 in tarball CI build script and hopefully this will be enough.

@mdeme01 Do we really need NodeJS v18 for the new frontend to build, or was it specified simply as the current LTS version?

@intjftw, @zporky Do we still need these legacy tarball builds in Ericsson?

@mcserep mcserep added Target: Developer environment Developer environment issues consist of CodeCompass or 3rd-party build tooling, configuration or CI. Target: WebGUI Issues related to the web frontend. labels Aug 10, 2023
@mcserep mcserep added this to the Release Gershwin milestone Aug 10, 2023
@mcserep mcserep self-assigned this Aug 10, 2023
@mdeme01
Copy link
Collaborator

mdeme01 commented Aug 11, 2023

@mdeme01 Do we really need NodeJS v18 for the new frontend to build, or was it specified simply as the current LTS version?

I tested it and I didn't have any problems installing packages and building the application with Node v16, so it should be fine. I've only written v18 because it was the current LTS version at the time.

@mcserep
Copy link
Collaborator Author

mcserep commented Aug 11, 2023

I tested it and I didn't have any problems installing packages and building the application with Node v16, so it should be fine. I've only written v18 because it was the current LTS version at the time.

@mdeme01 Thanks for the quick response, I think we shall keep Node v18 in the documentation as a requirement, as the end of support for v16 is coming soon. But hopefully we can make this tarball build with it to support legacy operating systems in Ericsson.

Let's see whether pipeline succeeds 😄

@mcserep mcserep merged commit ea225a8 into Ericsson:master Aug 11, 2023
6 checks passed
@mcserep mcserep deleted the tarball-node-16 branch August 11, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Target: Developer environment Developer environment issues consist of CodeCompass or 3rd-party build tooling, configuration or CI. Target: WebGUI Issues related to the web frontend.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants