Add setting to change how severities are displayed #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discookie
force-pushed
the
ericsson/custom-severities
branch
from
c090d8f
to
9c9c473
Compare
Discookie
force-pushed
the
ericsson/custom-severities
branch
from
9c9c473
to
fda1961
Compare
| @@ -158,6 +158,14 @@ | |||
| "description": "Enable CodeLens for displaying the reproduction path", | |||
| "default": true | |||
| }, | |||
| "codechecker.editor.customBugSeverities": { | |||
There was a problem hiding this comment.
Maybe it would be more user friendly to use an enum setting:
"codechecker.editor.customBugSeverities": {
"type": "string",
"default": "Error",
"enum": [
"Error",
"Warning",
"Information",
"Hint"
],
"description": "Control how a bug is displayed in the editor, depending on what its severity is. Bugs can be displayed as 'Error', 'Warning', 'Information' or 'Hint'. By default, everything except 'STYLE' severity is displayed as an error."
}
so this setting would be a selection:
There was a problem hiding this comment.
Indeed, and turns out vscode supports enum selection within objects, which is nice to use.
Can't rename the column headers, but it doesn't really matter too much.
|
@MiklosMagyari Thanks! We added you as a maintainer so you can now theoretically approve PRs as well - that's required for merging here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139. Requires #140 for CI passing.
By default, all CodeChecker bug severities except STYLE are displayed as errors inside the editor. This PR adds a setting to enable changing how each of these severities are displayed.