Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Replace Binary with LargeBinary #3736

Closed
wants to merge 1 commit into from

Conversation

bachp
Copy link
Contributor

@bachp bachp commented Sep 2, 2022

Binary is deprecated in SQLAlchemy and was removed in 1.4.

It was just an alias for LargeBinary

This is a first step for #3607

Binary is deprecated in SQLAlchemy and was removed in 1.4
Copy link
Contributor

@vodorok vodorok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bachp! I apologize for neglecting this PR for this long. Great work so far, but we also have schema migrations under web/server/codechecker_server/migrations/report/versions. Could you please check, what happens in the case of a db migration in which we want to migrate an existing database with Binary columns to a database with LargeBinary columns?

@whisperity
Copy link
Contributor

Dear @bachp,

Thank you for your contribution! I later independently arrived at the same conclusion you did. Due to a larger set of related changes to using (Large)Binarys, I have incorporated your changes with some slight cosmetic touch-ups (making sure the imported symbol names are sorted alphabetically) into #4089.

I will close this pull request due to this, but rest assured, your contribution will be attributed in a separate commit merged with #4089's eventual merge.

@whisperity whisperity added database 🗄️ Issues related to the database schema. refactoring 😡 ➡️ 🙂 Refactoring code. labels Dec 7, 2023
@whisperity whisperity closed this Dec 8, 2023
@whisperity
Copy link
Contributor

Dear @bachp,

2519a2f was merged in #4089. 👏

@bachp bachp deleted the sqlalchemy-largebinary branch March 2, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database 🗄️ Issues related to the database schema. refactoring 😡 ➡️ 🙂 Refactoring code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants