Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cfg] Using multiprocess lib instead of multiprocessing #4076

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

bruntib
Copy link
Contributor

@bruntib bruntib commented Nov 7, 2023

The standard multiprocessing lib has some issues mainly in Mac environment. Also, in Linux environment, too small system resources cause CodeChecker analyzer processes hang:
If the maximum number of processes (ulimit -u) is too small, then allocating a process pool with the standard multiprocessing lib raises a RuntimeError that can't be handled. With multiprocess lib another kind of exception is thrown, but the process itself doesn't hang.

The standard `multiprocessing` lib has some issues mainly in Mac
environment. Also, in Linux environment, too small system resources
cause CodeChecker analyzer processes hang:
If the maximum number of processes (`ulimit -u`) is too small, then
allocating a process pool with the standard `multiprocessing` lib raises
a RuntimeError that can't be handled. With `multiprocess` lib another
kind of exception is thrown, but the process itself doesn't hang.
@bruntib bruntib added CLI 💻 Related to the command-line interface, such as the cmd, store, etc. commands config ⚙️ dependencies 📦 Pull requests that update a dependency file labels Nov 7, 2023
@bruntib bruntib added this to the release 6.23.0 milestone Nov 7, 2023
@bruntib bruntib requested a review from vodorok as a code owner November 7, 2023 10:05
@bruntib bruntib requested review from dkrupp and Szelethus November 7, 2023 10:25
@dkrupp dkrupp modified the milestones: release 6.23.0, release 6.23.0-rc2 Nov 9, 2023
Copy link
Member

@dkrupp dkrupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tested the analysis and store on multiple open source projects.
The analysis/storage time did not increase and there is not additional error.

@dkrupp dkrupp merged commit 262a78f into Ericsson:master Nov 16, 2023
8 checks passed
@dkrupp
Copy link
Member

dkrupp commented Nov 16, 2023

fixes #4079

This was referenced Nov 16, 2023
@whisperity whisperity modified the milestones: release 6.23.0-rc2, release 6.23.0 Nov 17, 2023
@bruntib bruntib deleted the multiprocess_lib branch November 20, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI 💻 Related to the command-line interface, such as the cmd, store, etc. commands config ⚙️ dependencies 📦 Pull requests that update a dependency file platform-macOS 🍎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants