[fix] Bugfix at --enable-all and disable warning #4080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug in CodeChecker: CodeChecker analyze --enable-all --disable clang-diagnostic-unused-variable This command didn't disable that warning. The problem is that we represent --enable-all with -Weverything in the clang-tidy analyzer command, but -Wno-unused-variable has to be appended too. It was a false assumption that "clang-tidy -checks='-clang-diagnostic-unused-variable' main.c -- -Weverything" does the job.
bruntib
added
bugfix 🔨
analyzer 📈
Earlier we collected the enabled/disabled checkers in a set which results non-determinism in the appearance of clang-tidy checkers. Instead of sets we're using lists now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[fix] Bugfix at --enable-all and disable warning
There was a bug in CodeChecker:
CodeChecker analyze --enable-all --disable clang-diagnostic-unused-variable
This command didn't disable that warning. The problem is that we represent --enable-all with -Weverything in the clang-tidy analyzer command, but -Wno-unused-variable has to be appended too. It was a false assumption that
"clang-tidy -checks='-clang-diagnostic-unused-variable' main.c -- -Weverything" does the job.
[fix] Fix non-determinism of clang-diagnostic checker appearances
Earlier we collected the enabled/disabled checkers in a set which
results non-determinism in the appearance of clang-tidy checkers.
Instead of sets we're using lists now.