[cmd][store] Add multiprocess-based store to MacOS and Windows
#4118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vodorok
force-pushed
the
osx_and_windows_multp
branch
3 times, most recently
from
7a64867 to
fb7bfda
Compare
vodorok
force-pushed
the
osx_and_windows_multp
branch
from
fb7bfda to
256fe33
Compare
|
Thanks @whisperity for the idea of the compatibility module. |
vodorok
changed the title
vodorok
force-pushed
the
osx_and_windows_multp
branch
from
256fe33 to
e7cbd59
Compare
whisperity
changed the title
whisperity
changed the title
whisperity
added
CLI 💻
whisperity
reviewed
Dec 8, 2023
whisperity
changed the title
multiprocess-based store to MacOS and Windows
vodorok
force-pushed
the
osx_and_windows_multp
branch
from
e7cbd59 to
621c761
Compare
Introducing multiprocessing to the store command for Windows and OSX platforms. Linux still uses processpool executor
vodorok
force-pushed
the
osx_and_windows_multp
branch
from
621c761 to
d56e216
Compare
whisperity
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing multiprocessing to the store command for Windows and OSX platforms.
Linux still uses processpool executor
The previous implementation switched completely to the multiprocess module but the web tests got flaky.
See #4095