Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[analyzer] Ignore -fno-tree-dominator-opts #4141

Merged
merged 1 commit into from
Jan 8, 2024
Merged

[analyzer] Ignore -fno-tree-dominator-opts #4141

merged 1 commit into from
Jan 8, 2024

Conversation

bo-dani
Copy link
Contributor

@bo-dani bo-dani commented Dec 22, 2023 •
edited
Loading

The -fno-tree-dominator-opts GCC option is not recognized by clang.

@bo-dani bo-dani changed the title Ignore -fno-move-loop-invariants [analyzer] Ignore -fno-move-loop-invariants Dec 22, 2023
bruntib
bruntib requested changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@bruntib bruntib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!
Could you, please, change the commit message so it includes -fno-tree-dominator-opts instead of -fno-move-loop-invariants?
Thank you!

@bo-dani
Copy link
Contributor Author

bo-dani commented Jan 8, 2024

Thanks for the patch! Could you, please, change the commit message so it includes -fno-tree-dominator-opts instead of -fno-move-loop-invariants? Thank you!

Oops, brainfart from my side :)

@bo-dani bo-dani changed the title [analyzer] Ignore -fno-move-loop-invariants [analyzer] Ignore -fno-tree-dominator-opts Jan 8, 2024
@bruntib bruntib merged commit b23833d into Ericsson:master Jan 8, 2024
7 of 8 checks passed
@whisperity whisperity added analyzer 📈 Related to the analyze commands (analysis driver) config ⚙️ clang-tidy 🐉 clang-tidy is a clang-based C++ “linter” tool. labels Mar 27, 2024
@whisperity whisperity added this to the release 6.24.0 milestone Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruntib bruntib bruntib approved these changes

@vodorok vodorok Awaiting requested review from vodorok vodorok is a code owner

Assignees
No one assigned
Labels
analyzer 📈 Related to the analyze commands (analysis driver) clang-tidy 🐉 clang-tidy is a clang-based C++ “linter” tool. config ⚙️
Projects
None yet
Milestone
release 6.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bo-dani @bruntib @whisperity