Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): Apply invariant fixes from label-tool #4291

Merged
merged 1 commit into from
Aug 13, 2024
Merged

chore(config): Apply invariant fixes from label-tool #4291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions config/labels/analyzers/clang-tidy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1798,7 +1798,9 @@
"guideline:sei-cert",
"label-tool-skip:severity",
"profile:default",
"profile:extreme",
"profile:security",
"profile:sensitive",
"sei-cert:exp33-c",
"severity:HIGH"
],
Expand Down Expand Up @@ -3190,8 +3192,8 @@
"doc_url:https://clang.llvm.org/docs/DiagnosticsReference.html#winvalid-noreturn",
"guideline:sei-cert",
"profile:security",
"severity:MEDIUM",
"sei-cert:msc53-cpp"
"sei-cert:msc53-cpp",
"severity:MEDIUM"
],
"clang-diagnostic-invalid-offsetof": [
"doc_url:https://clang.llvm.org/docs/DiagnosticsReference.html#winvalid-offsetof",
Expand Down Expand Up @@ -4166,10 +4168,10 @@
"guideline:sei-cert",
"label-tool-skip:severity",
"profile:default",
"sei-cert:exp45-c",
"profile:extreme",
"profile:security",
"profile:sensitive",
"sei-cert:exp45-c",
"severity:MEDIUM"
],
"clang-diagnostic-parentheses-equality": [
Expand Down
2 changes: 1 addition & 1 deletion config/labels/analyzers/clangsa.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,7 +875,6 @@
"profile:default",
"profile:extreme",
"profile:security",
"profile:security",
"profile:sensitive",
"sei-cert:env31-c",
"sei-cert:env34-c",
Expand Down Expand Up @@ -1077,6 +1076,7 @@
],
"unix.cstring.NullArg": [
"doc_url:https://clang.llvm.org/docs/analyzer/checkers.html#unix-cstring-nullarg-c",
"guideline:sei-cert",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only behavioural change, but if someone uses analyse --disable default --enable guideline:sei-cert (or however it should be specified...) then they will start seeing this checker, which changes the potentially reported set of bugs.

"profile:default",
"profile:extreme",
"profile:security",
Expand Down
Loading
Loading