Analyzer binary dependent environment #4305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkrupp
force-pushed
the
env_fix
branch
2 times, most recently
from
fa85919 to
43be7f0
Compare
If a pre-package analyzer binary (e.g. clang) is found first, the LD_LIBRARY_PATH must be extended. On the other hand, if the analyzer binary is taken from the users machine, the original environment must be used to execute the binary. This patch introduces an analyzer binary dependent environment initialization.
bruntib
requested changes
Aug 12, 2024
There was a problem hiding this comment.
SourceAnalyzer class has a virtual function: analyze(). This sets the environment accordingly. The inherited Gcc and Cppcheck classes override this function which also set the environment. I think, we shouldn't expect the child classes do this job. The analyze() functions in these two inherited classes could be removed.
Co-authored-by: bruntib <bruntib@users.noreply.github.com>
Good point! Fixed! |
bruntib
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a pre-package analyzer binary (e.g. clang) is found first, the LD_LIBRARY_PATH must be extended. On the other hand, if the analyzer binary is taken from the users machine, the original environment must be used to execute the binary.
This patch introduces an analyzer binary dependent environment initialization.