[fix] Don't reset PATH in Cppcheck plugin #4320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Cppcheck plugin resets the PATH environment variable. It is usually not a good idea to overwrite PATH instead of extending it. In this specific case it caused an actual error: When tests are executed one after the other, this statement clears that PATH and later tests (e.g. test_env_var.py) run in an environment where PATH is technically empty. This test fails.
bruntib
added
test ☑️
cservakt
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Cppcheck plugin resets the PATH environment variable. It is usually not a good idea to overwrite PATH instead of extending it. In this specific case it caused an actual error: When tests are executed one after the other, this statement clears that PATH and later tests (e.g. test_env_var.py) run in an environment where PATH is technically empty. This test fails.