[feat] Introduce chronological order for dynamic reports #4450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruntib
force-pushed
the
typed_annotations
branch
2 times, most recently
from
4cfb3f9 to
ab544a8
Compare
cservakt
reviewed
Feb 11, 2025
Comment on lines
1029
to
1030
| SortType.CHRONOLOGICAL_ORDER: [('annotation_chronological-order', | ||
| 'annotation_chronological-order')]} |
There was a problem hiding this comment.
The naming convention here may not be consistent. It would be better to use snake_case and display it with a hyphen only in the GUI.
|
|
||
| report_annotation_types = { | ||
| "timestamp": __allowed_types["datetime"], | ||
| "testsuite": __allowed_types["string"], |
There was a problem hiding this comment.
Do we use the testsuite annotation anywhere? If not, it might be unnecessary and can be removed from the list.
dkrupp
requested changes
Feb 11, 2025
bruntib
force-pushed
the
typed_annotations
branch
3 times, most recently
from
c0a7892 to
7380728
Compare
Reports' can be assigned some labels. It is useful especially for dynamic analyzer reports for storing their timestamps or test cases during which they appeared. Now it is possible to store a "chronological-order" annotation which is a simple integer counter.
bruntib
force-pushed
the
typed_annotations
branch
from
7380728 to
c0fa99e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reports' can be assigned some labels. It is useful especially for dynamic analyzer reports for storing their timestamps or test cases during which they appeared.
Now it is possible to store a "chronological-order" annotation which is a simple integer counter.