Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libffi: 3.2 is also broken for 64-bit; use frida version #13

Merged
merged 1 commit into from
Apr 13, 2015
Merged

libffi: 3.2 is also broken for 64-bit; use frida version #13

merged 1 commit into from
Apr 13, 2015

Conversation

nirbheek
Copy link
Contributor

Seems ARM64 libffi is still broken when used with Bowser, so let's use frida's
libffi which they say works on multiple platforms

EricssonResearch/openwebrtc#177 (comment)

@nirbheek
Copy link
Contributor Author

While testing, you'll want to do rm -rf ~/cerbero/dist/android_armv7/lib/libffi-3.2.1/ to get rid of the old headers (although the pkg-config file has the updated path, so in theory this shouldn't be needed)

autoreconf = True
commit = '20562ac0427c3578250d04c6e34fb0127d4551cf'
commit = 'frida/master'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the a fixed commit here as well: 4e2166049f897a904e4c3ce367e4e8ddb54e0ad0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hesitated with that because there was no clear way to ensure that the commit id would be chosen from the "frida" remote, and not "origin".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine, if origin has an identical commit we might as well use that one :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the older commits in that sequence of commits might be different!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit id changes if the history to that commit changes

Seems ARM64 libffi is still broken when used with Bowser, so let's use frida's
libffi which they say works on multiple platforms

EricssonResearch/openwebrtc#177 (comment)
@nirbheek
Copy link
Contributor Author

Comments should be addressed now. :)

@Rugvip Rugvip merged commit 5c8e6e8 into EricssonResearch:master Apr 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants