Update Handlebars for 2.1 preview1

[ErikEJ]

From @ErikEJ on March 27, 2018 8:35

Describe what is not working as expected.

Steps to reproduce

Include a complete description that I can redo to reproduce the issue.

Further technical details

Toolbox/Power Tools version: (found in About dialog - blue questionmark icon)

Database engine: (SQlite, SQL Compact or SQL Server)

Visual Studio or SSMS version: (e.g. Visual Studio 2017 15.3, SSMS 17.3)

Copied from original issue: ErikEJ/SqlCeToolbox#666

[ErikEJ]

From @OmiCron07 on May 7, 2018 21:40

When will the templates come back?

[ErikEJ]

Only @tonysneed knows ??

[ErikEJ]

From @tonysneed on May 8, 2018 10:48

I finally have some bandwidth to tackle this. Stay tuned.

[ErikEJ]

From @tonysneed on May 12, 2018 21:38

Now that EF 2.1 is RC, I plan to update my extensions. I should have time to get started this week, but I'll definitely get it done within the next two weeks.

[ErikEJ]

@tonysneed Ping?

[tonysneed]

I am deep into this. What's blocking me right now is a failing test with IReverseEngineerScaffolder.ScaffoldModel, where the columns from my models aren't getting mapped. This used to work before, but it seems to be a breaking change of some sort with EF Core 2.1.

I'm thinking that I need to register a IDesignTimeDbContextFactory implementation in my test. Trying that now.

[ErikEJ]

Thanks a lot for the update!

[tonysneed]

Well that didn't work ... Could use someone to help me sort this out. I've narrowed it down to RelationalScaffoldingModelFactory.GetTypeScaffoldingInfo, where this line is returning null:

TypeScaffoldingInfo mapping = this._scaffoldingTypeMapper.FindMapping(column.GetUnderlyingStoreType() ?? column.StoreType, column.IsKeyOrIndex(), column.IsRowVersion());

[tonysneed]

This is without any of my Handlebars templates in the mix. It's basically just trying to reverse engineer a database from within a unit test. The EF Core code base does not have an example of doing that, so I'm pretty much on my own.

[ErikEJ]

@tonysneed Could you share a branch with actual code, then maybe @bricelam could help? 🙏

[ErikEJ]

@tonysneed Have you look at this: https://github.com/ErikEJ/EFCorePowerTools/blob/master/src/GUI/ReverseEngineer20/EFCoreReverseEngineer.cs (not sure it will be of much help)

[tonysneed]

@ErikEJ Thanks, having a look.

[bricelam]

Here's the heart of our functional tests which generate code from a model, compile it, and load it back: https://github.com/aspnet/EntityFrameworkCore/blob/dev/test/EFCore.Design.Tests/Scaffolding/Internal/ModelCodeGeneratorTestBase.cs

[tonysneed]

Perfect, thanks guys. ConfigureDesignTimeServices was what I was missing. I'm unblocked now.

[tonysneed]

This issue is resolved with release 1.0.0-rc1.
The NuGet package has also been published: https://www.nuget.org/packages/EntityFrameworkCore.Scaffolding.Handlebars/1.0.0-rc

[ErikEJ]

Great, I will try to integrate - I had to make some changes the last time, so using the source (also need strong named assemblies)

[tonysneed]

I might be able to help with that .. perhaps fork the Handlebars.Net repo and strongly name it. Then I can strongly name mine too. Make your life easier. :)

[ErikEJ]

Sounds great - Maybe wait until after I find out if I need to make any changes (I did the last time)

[ErikEJ]

TrackableEntities/EntityFrameworkCore.Scaffolding.Handlebars#12

[tonysneed]

Addressed here and here.

[ErikEJ]

Thanks a lot, Tony, will give it a try and let you know

[tonysneed]

@ErikEJ I went ahead and published the signed package: https://www.nuget.org/packages/EntityFrameworkCore.Scaffolding.Handlebars/1.0.0-rc2. So just install it normally.