Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on .NET 7 project #1339

Closed
YuhanKun opened this issue Apr 14, 2022 · 5 comments
Closed

Not working on .NET 7 project #1339

YuhanKun opened this issue Apr 14, 2022 · 5 comments
Labels
duplicate This issue or pull request already exists

Comments

@YuhanKun
Copy link

YuhanKun commented Apr 14, 2022

image
Add .NET 7 check to

public static async Task<bool> IsNetCore31OrHigherAsync(this Project project)
{
return await IsNetCore31Async(project) || await IsNet50Async(project) || await IsNet60Async(project);
}
should resolve the problem

Steps to reproduce

Open a .NET 7 project in VS2022
Right-click on the project then "EF Core Power Tools > Add DbContext Diagram"

Further technical details

EF Core version in use: EF Core 6

Is Handlebars used: no

EF Core Power Tools version: 2.5.918.0

Database engine: MySQL

Visual Studio version: Visual Studio 2022

@ErikEJ
Copy link
Owner

ErikEJ commented Apr 14, 2022

Currently .net 7 projects are actually nit supported. Updating the check will not work.

@YuhanKun
Copy link
Author

Currently .net 7 projects are actually nit supported. Updating the check will not work.

I see.
Hope this extension can be support .NET 7 projects soon in the future
Thanks for your great extension. 😁

@ErikEJ
Copy link
Owner

ErikEJ commented Apr 14, 2022

Thanks - if it is for DbContext diagrams I think I can enable quite soon.

@ErikEJ ErikEJ reopened this Apr 16, 2022
@ErikEJ
Copy link
Owner

ErikEJ commented Apr 19, 2022

Closing in favor of #1345

@ErikEJ ErikEJ closed this as completed Apr 19, 2022
@ErikEJ ErikEJ added the duplicate This issue or pull request already exists label Apr 25, 2022
ErikEJ added a commit that referenced this issue May 27, 2022
@ErikEJ
Copy link
Owner

ErikEJ commented Jul 13, 2022

@YuhanKun This has now been implemented in the latest daily build. Please let me know if it works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants