Enhance setting renaming #317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayletdomybest
force-pushed
the
feature/Enhance-setting-rename2
branch
from
1ca325a to
7214646
Compare
ErikEJ
reviewed
Nov 27, 2019
src/GUI/ReverseEngineer20/ReverseEngineer/ReplacingCandidateNamingService.cs
Show resolved
Hide resolved
|
Could you add some tests? |
|
Sure I push unit test for it |
ErikEJ
reviewed
Nov 27, 2019
src/GUI/UnitTests/PluralizerTest.cs
Outdated
| var actResult = sut.Pluralize("OldTable"); | ||
|
|
||
| //Assert | ||
| StringAssert.Contains(expected, actResult); |
ErikEJ
reviewed
Nov 27, 2019
src/GUI/UnitTests/PluralizerTest.cs
Outdated
| new TableRenamer | ||
| { | ||
| Name = "old_table", | ||
| VariableName = "TableVariables", |
ErikEJ
reviewed
Nov 27, 2019
ErikEJ
reviewed
Nov 27, 2019
|
|
||
| namespace ReverseEngineer20.ReverseEngineer | ||
| { | ||
| public class InflectorPluralizer : IPluralizer | ||
| { | ||
| private readonly Dictionary<string, string> _customerCharacterPluralize; |
ErikEJ
reviewed
Nov 27, 2019
| .Where(x => !string.IsNullOrWhiteSpace(x.VariableName)) | ||
| .ToDictionary(key => key.Name.ToPascalCase(), value => value.VariableName); | ||
|
|
||
| _customerCharacterSingularize = customReplacers |
There was a problem hiding this comment.
Will this not always block standard renaming from working?
There was a problem hiding this comment.
I don't known what's your meaning
I think If you want to custom name, you only want your name is equals your naming not be transfer by other function?
hayletdomybest
force-pushed
the
feature/Enhance-setting-rename2
branch
from
dc9371f to
d679f76
Compare
hayletdomybest
force-pushed
the
feature/Enhance-setting-rename2
branch
from
d679f76 to
b4dfc22
Compare
|
This looks good, will just let it sit for while until the EF Core 3.1 dust settles |
|
Closing in favor of: #496 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello I modify this #316
and I provider a better way to setting name by configure file, but this method can't not distinguish schema name