Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for ldap servers requiring authentication for read access #259

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

mljohns89
Copy link
Contributor

Have you read the docs first?
Yes
OK, describe you changes:
One line changer to cause Spring Security to trigger required config generation for LDAP Servers that require authentication.

Per Spring Docs, calling this method is required when implementations are outside of the Spring Context (which LDAPAuthenticator is): https://github.com/spring-projects/spring-ldap/blob/main/core/src/main/java/org/springframework/ldap/core/support/AbstractContextSource.java#L60-L62

Method call for reference: https://github.com/spring-projects/spring-ldap/blob/main/core/src/main/java/org/springframework/ldap/core/support/AbstractContextSource.java#L409

Tests?
Didn't add any since it's a one liner and would require a lot of setup for an in-memory secure ldap server

@albogdano albogdano merged commit 0eef624 into Erudika:master Apr 1, 2024
1 check passed
@albogdano
Copy link
Member

Thank you very much for the PR, Michael! I was unaware of that method. 👍
I will publish a new version soon. Right now, I'm in the process of migrating Para to Spring 3.x.

@mljohns89 mljohns89 deleted the ldap-authenticated-read-access branch April 1, 2024 18:27
@mljohns89
Copy link
Contributor Author

@albogdano Thanks so much. Do you have rough a time frame by any chance?

@albogdano
Copy link
Member

@mljohns89 I just released 1.49.4 containing your PR because the migration to Spring 3.x is taking a bit longer than I anticipated.

@mljohns89
Copy link
Contributor Author

@albogdano Awesome! Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants