Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you read the docs first?
Yes
OK, describe you changes:
The test
com.erudika.para.persistence.MockDAOTest#testReadPage
is Flaky. It is failing when run several times with different initial random seeds. The root cause is when reading DAO to pages it assumes theMAPS
is ordered while it is not.The
ConcurrentHashMap
class does not guarantee the order of map when accessing it each time. This solution is to sort the Map before working on order dependent jobs.Tests?
The test I use is
mvn -pl para-server edu.illinois:nondex-maven-plugin:1.1.2:nondex -Dtest=com.erudika.para.persistence.MockDAOTest#testReadPage
. You can also specify the number of runs with-DnondexRuns=NUMBER