Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created the home page and the navbar component the routing work is no… #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Gmin2
Copy link

@Gmin2 Gmin2 commented Oct 5, 2023

Screenshot (64)
added the homepage and the navbar although the routing part is not added properly
solves issues #2

Copy link
Owner

@EshaanAgg EshaanAgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI looks good but needs some changes.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not delete this file.

@@ -5,4 +5,5 @@ import tailwind from "@astrojs/tailwind";
// https://astro.build/config
export default defineConfig({
integrations: [tailwind()]

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this new line.

Comment on lines +16 to +17
"react-icons": "^4.11.0",
"rehype-external-links": "^3.0.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need these new packages? Try using Astro Icon as much as possible.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont we need rehype-external-links for google fonts link in the layout.astro page

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace this with a .svg or .webp.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace with .svg

Comment on lines +11 to +36
const allOrganizations = await response.json();




---

<Layout title="LFX Mentorship Metrics">
<main>
<ul role="list" class="grid grid-cols-4 gap-4">
{
allOrganizations.map((org: Organization) => (
<OrganizationCard
title={org.name}
logoUrl={org.logoUrl}
id={org.id}
/>
))
}
</ul>





</main>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all the extra newlines and format the code properly.

Comment on lines +12 to +14
<a href="/" class="relative group ml-9">
<span class="relative z-10">Home</span>
<span class="absolute bottom-[-5px] left-0 w-full h-1 bg-blue-200 transform scale-x-0 origin-left transition-transform group-hover:scale-x-100"></span>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Define a NavItem component and then loop over it. It would save the repetition of the same styles.

LFX
</div>
<div class="text-white text-[90px] font-bold leading-normal">
Matrix
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics

Matrix
</div>
<div class="relative text-[24px] leading-normal font-normal">
LFX Matrix makes it easy to sponsor and help train the next generation of open source developers by serving key needs of the community. Invest in building a stronger and more diverse community of qualified developers and engineers.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFX Metrics

Comment on lines +17 to +25

<!--
font-family
-->

<link rel="preconnect" href="https://fonts.googleapis.com">
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
<link href="https://fonts.googleapis.com/css2?family=Lato:ital,wght@0,300;0,400;0,700;0,900;1,100;1,400;1,700;1,900&family=Plus+Jakarta+Sans:ital,wght@0,200;0,300;0,400;1,200;1,300&family=Poppins:ital,wght@0,200;1,200&family=Roboto:wght@300;400&display=swap" rel="stylesheet">

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properly indent the code. Use Astro's VS Code extension to auto-format the code for constitency.

@Gmin2
Copy link
Author

Gmin2 commented Oct 6, 2023

Screenshot (65)
when i have made the changes that you have mention above it is showing this error when i remove all the changes that i have made the page still give this error. Please can you specify what error i am facing

@EshaanAgg
Copy link
Owner

Your branch has some conflicts. Push the latest code for the frontend and backend repos, and then try to make the changes. If the error persists, please give a more descriptive description of where the error is. This screen is too general to debug the error.

@Gmin2
Copy link
Author

Gmin2 commented Oct 28, 2023

bhaiya the error is still there
what should i do

@EshaanAgg
Copy link
Owner

@Min2who Your branch is way behind the current progress. Please pull the latest changes for the frontend as well as the backend, install the dependencies again, and then try. It should fix most of your issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants