avoid flush repeatedly when has finished flushing #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theigl
requested changes
Jul 5, 2021
| @@ -58,8 +58,9 @@ public void flush () throws KryoException { | |||
| } catch (IOException ex) { | |||
| throw new KryoException(ex); | |||
| } | |||
| }else{ | |||
There was a problem hiding this comment.
Please apply project formatting to your changes. There should be whitespace around the else.
There was a problem hiding this comment.
thank you , i have formtted
|
Thanks @jackjoesh! I think this change makes sense and I will apply it. |
thank you for checking |
|
Thanks again @jackjoesh! |
ankit-harness
pushed a commit
to ankit-harness/kryo
that referenced
this pull request
May 10, 2023
* avoid repeat flush when position finish * Formatting Co-authored-by: jerry.l <jerry.l@binance.com> Co-authored-by: Thomas Heigl <thomas.heigl@gmail.com>
ankit-harness
added a commit
to ankit-harness/kryo
that referenced
this pull request
May 10, 2023
…ftware#839)" This reverts commit d693aa5.
theigl
added a commit
that referenced
this pull request
May 19, 2023
* avoid flush repeatedly when has finished flushing (#839) * avoid repeat flush when position finish * Formatting Co-authored-by: jerry.l <jerry.l@binance.com> Co-authored-by: Thomas Heigl <thomas.heigl@gmail.com> * Revert "avoid flush repeatedly when has finished flushing (#839)" This reverts commit d693aa5. * avoid flush repeatedly when has finished flushing --------- Co-authored-by: jackjoesh <jackjoesh@sina.com> Co-authored-by: jerry.l <jerry.l@binance.com> Co-authored-by: Thomas Heigl <thomas.heigl@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify content： avoid flush repeatedly when has finished flushing.
After my testing ,this modification can save cpu usage in high concurrency service.