-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add separate step to GHA workflow for rust doc #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd make sense for the documentation steps to be moved to .github/workflows/doc.yml
or something
I'm going to leave this open until we get access to rust 1.60.0 since this is needed for the workflow to pass |
I think that we should switch this CI to a github runner for now: From - name: Checkout Repository
uses: actions/checkout@v3
- name: Configure Git
run: |
git config --global url."https://ancient123:${{ secrets.ORG_GITHUB_PATH }}@github.com/".insteadOf git://github.com/
git config --global url."https://ancient123:${{ secrets.ORG_GITHUB_PAT }}@github.com/".insteadOf ssh://git@github.com/
- name: Install stable toolchain
uses: actions-rs/toolchain@v1
with:
profile: default
toolchain: stable
override: true
default: true
components: rustfmt, clippy
- name: Enable Rust Caching
uses: Swatinem/rust-cache@v1 Should get rust 1.60 |
This PR closes #115 and:
flake.lock
cargo doc
so we can view warningscargo doc
invocation. Now it generates private documentation for all workspace members and all examplesNote that if this check fails locally, it may be a rust stable. Rust stable needs to be at least 1.60.0 which came out very recently (<1 hour at the time of posting). Fenix hasn't run the workflow to generate a new stable toolchain yet.