[DRB] - Store DRB seed and epoch root with consistent block info #4019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
ss-es
reviewed
Jan 10, 2025
ss-es
approved these changes
Jan 13, 2025
crates/task-impls/src/helpers.rs
Outdated
Comment on lines
334
to
337
| } else { | ||
| tracing::warn!( | ||
| "No decided leaf while a view has been decided, which should be impossible." | ||
| ); |
There was a problem hiding this comment.
I feel like this might sometimes happen with the way our code is written, but I'm not 100% sure either way. I don't think we necessarily need to log here, but no strong opinion
There was a problem hiding this comment.
Changed this to an info log and removed "which should be impossible", to still log something but not indicate an error.
crates/task-impls/src/helpers.rs
Outdated
Comment on lines
495
to
496
| tracing::warn!( | ||
| "No decided leaf while a view has been decided, which should be impossible." |
Comment on lines
277
to
285
| // Skip if we are not in the committee of the next epoch. | ||
| if !task_state | ||
| .membership | ||
| .read() | ||
| .await | ||
| .has_stake(&task_state.public_key, current_epoch_number + 1) | ||
| { | ||
| return Ok(()); | ||
| } |
There was a problem hiding this comment.
does it make sense to remove the has_stake check here too?
ss-es
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3998. Closes #4008.
This PR:
store_received_drb_resultinsidestore_drb_seed_and_resultto handle storing the seed, the received result, and the computed result together.store_drb_seed_and_resultto use the decided block rather than the newly proposed block for storing the DRB seed.decide_from_proposal_add_epoch_roottodecide_epoch_root.decide_epoch_rootfor adding epoch root.