Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: only build without lockfile if dependencies changed #2643

Merged
merged 8 commits into from
Feb 19, 2025
Merged

CI: only build without lockfile if dependencies changed #2643

merged 8 commits into from
Feb 19, 2025

Conversation

sveitser
Copy link
Collaborator

@sveitser sveitser commented Feb 19, 2025 •
edited
Loading

  • Do not run this check on PRs unless dependencies are modified.
  • Comment on the PR in case of failure to communicate that PR can still be merged. There is such an example comment below.
  • Add badge to readme to make failures on main or scheduled builds visible.

@sveitser
CI: build without lockfile if dependencies changed
3b75fbc 
- Makes this job less noisy if dependencies weren't modified.
- Comment on the PR in case of failure to communicate that PR can still
  be merged.
- Add badge to readme to make failures on main or scheduled builds
  visible.
@sveitser
CI: debugging
45e5ea1
@sveitser
this job actually fails already
43ed23a
@sveitser
Only comment once
3c91a21
@sveitser
fix yaml indent
9d740b1
@github-actions GitHub Actions
Copy link
Contributor

Unable to build without Cargo.lock file.

This means that after this change 3rd party projects may have
difficulties using crates in this repo as a dependency. If this
isn't easy to fix please open an issue so we can fix it later.

For the failing build see: https://github.com/EspressoSystems/espresso-sequencer/actions/runs/13412323018

To reproduce locally run

cargo generate-lockfile
cargo check --all-targets

This PR can still be merged.

@sveitser sveitser marked this pull request as ready for review February 19, 2025 12:50
@sveitser sveitser requested review from ss-es and pls148 February 19, 2025 12:51
@EspressoSystems EspressoSystems deleted a comment from github-actions bot Feb 19, 2025
@sveitser sveitser changed the title CI: build without lockfile if dependencies changed CI: only build without lockfile if dependencies changed Feb 19, 2025
@sveitser sveitser merged commit 26ef084 into main Feb 19, 2025
52 checks passed
@sveitser sveitser deleted the ma/ci-without-lockfile-file-gating branch February 19, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszrzasik lukaszrzasik lukaszrzasik approved these changes

@philippecamacho philippecamacho Awaiting requested review from philippecamacho philippecamacho is a code owner

@ImJeremyHe ImJeremyHe Awaiting requested review from ImJeremyHe ImJeremyHe is a code owner

@jbearer jbearer Awaiting requested review from jbearer jbearer is a code owner

@tbro tbro Awaiting requested review from tbro tbro is a code owner

@imabdulbasit imabdulbasit Awaiting requested review from imabdulbasit imabdulbasit is a code owner

@ss-es ss-es Awaiting requested review from ss-es

@pls148 pls148 Awaiting requested review from pls148

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sveitser @lukaszrzasik