feat: add support for html 5 tags #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for the following HTML 5 tags with the `style` attribute: * `article` * `aside` * `details` * `footer` * `header` * `main` * `mark` * `nav` * `section` * `summary` * `time` Adds test case for sanitization of contents of `pre` tag. Also adds the `aria-label` and `aria-hidden` attributes to the `div` tag.
BlakeStearman
commented
Apr 29, 2024
| @@ -50,13 +50,13 @@ describe("Sanitizer", () => { | |||
|
|
|||
| // Extending the defaults | |||
| const sanitizer2 = new Sanitizer( | |||
| { allowCommentTag: false, whiteList: { blockquote: [] } }, | |||
| { allowCommentTag: false, whiteList: { blink: [] } }, | |||
There was a problem hiding this comment.
The test for extending the defaults was changed since we added blockquote to the main whitelist.
dasa
approved these changes
Apr 29, 2024
Good catch. Description has been updated. |
ssylvia
approved these changes
Apr 29, 2024
|
sorry Im late to the review, but I think this pr should have also included the css edits too? |
|
@CodeBarker I did not include those, no. I can take another pass at addressing those specifically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the following HTML 5 tags with the
styleattribute:articleasidedetailsfooterheadermainmarknavsectionsummarytimeAdds
pre,code, andblockquotetags withstyleattribute.Adds test case for sanitization of contents of
pretag.Also adds the
aria-labelandaria-hiddenattributes to thedivtag.