Hud10837/session init and permissions #595

hud10837 · 2024-09-30T13:47:06Z

Related to issue: https://devtopia.esri.com/runtime/kotlin/issues/4680

Description:

Adds session initialization and automatic permission requests to the TableTopSceneView. Note that while the session is initialized by the component, the user will have to manually ensure that Google Play Services for AR is installed. This is demonstrated in the microapp

Summary of changes:

Adds a new TableTopSceneViewInitializationStatus and associated lambda callback parameter on the TableTopSceneView so the user can be notified when the TableTopSceneView is ready and when any error occurs, such as if Google Play Services for AR is not installed
Requests camera permissions automatically using a new function rememberCameraPermission. The user can specify whether the component should actually perform the permission request by specificying the parameter requestCameraPermissionAutomatically. If this is set to false, then when the permission is required, TableTopSceneViewInitializationStatus will be set to FailedToInitialize. The user may want to specify this as false if they want to show a rationale for the permission.
Modifies how the component is displayed when the permission is not granted or ARCore is not available
Modifies the microapp to demonstrate how to setup ARCore
Fixes an issue with the resources file, which was located in the wrong place

Pre-merge Checklist

a vTest Job for this PR has been run
- link: https://runtime-kotlin.esri.com/view/all/job/vtest/job/toolkit/121/
Unit and/or integration tests have been added to exercise this PR's logic, and the tests are passing:
- Yes
- No

hud10837 · 2024-10-01T06:34:51Z

toolkit/ar/src/main/assets/shaders/background_show_camera.frag

These shader files were moved because the code from the feature branch wasn't compiling

Will they be re-added in a subsequent PR?

They haven't been removed, just changed the location of the assets directory

gunt0001 · 2024-10-01T13:53:05Z

microapps/ArTabletopApp/app/src/main/java/com/arcgismaps/toolkit/artabletopapp/MainActivity.kt

 import androidx.compose.ui.Modifier
+import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.tooling.preview.Preview


unused import

gunt0001 · 2024-10-01T13:57:04Z

microapps/ArTabletopApp/app/src/main/java/com/arcgismaps/toolkit/artabletopapp/MainActivity.kt

+    private var userRequestedInstall: Boolean = true
+
+    private val _isGooglePlayServicesArInstalled = MutableStateFlow(false)
+    private val isGooglePlayServicesArInstalled = _isGooglePlayServicesArInstalled.asStateFlow()


No need for a read-only flow here, since this is not API. Having the MutableStateFlow should be sufficient

gunt0001 · 2024-10-01T14:02:31Z

microapps/ArTabletopApp/app/src/main/res/values/strings.xml

@@ -18,4 +18,6 @@

 <resources>
    <string name="app_name">ArTabletopApp</string>
+    <string name="google_play_services_for_ar_must_be_installed_to_run_this_app">Google Play Services for AR must be installed to run this app.</string>


Could we make that name shorter, something like:

Suggested change

<string name="google_play_services_for_ar_must_be_installed_to_run_this_app">Google Play Services for AR must be installed to run this app.</string>

<string name="arcore_installed_message">Google Play Services for AR must be installed to run this app.</string>

gunt0001 · 2024-10-01T14:03:44Z

toolkit/ar/src/main/assets/shaders/background_show_camera.frag

Will they be re-added in a subsequent PR?

gunt0001 · 2024-10-01T14:05:04Z

toolkit/ar/src/main/java/com/arcgismaps/toolkit/ar/TableTopSceneView.kt

@@ -102,62 +122,150 @@ fun TableTopSceneView(
    onDrawStatusChanged: ((DrawStatus) -> Unit)? = null,
    content: (@Composable TableTopSceneViewScope.() -> Unit)? = null
 ) {
-    val lifecycleOwner = LocalLifecycleOwner.current
+    Box(modifier = modifier) {


Why has this Box moved up here again?

gunt0001 · 2024-10-01T14:17:41Z

toolkit/ar/src/main/java/com/arcgismaps/toolkit/ar/TableTopSceneView.kt

+                }
+            }
+        }
+        if (arCoreInstalled) {


Shouldn't this be:

Suggested change

if (arCoreInstalled) {

if (arCoreInstalled && cameraPermissionGranted) {

gunt0001 · 2024-10-01T14:21:46Z

toolkit/ar/src/main/java/com/arcgismaps/toolkit/ar/TableTopSceneView.kt

        )
    }
+    if (requestCameraPermissionAutomatically) {
+        val requestPermissionLauncher =


I think this can move into the if statement on line 253?

gunt0001 · 2024-10-01T14:24:05Z

toolkit/ar/src/main/java/com/arcgismaps/toolkit/ar/TableTopSceneViewInitializationStatus.kt

+ *
+ * @since 200.6.0
+ */
+sealed class TableTopSceneViewInitializationStatus {


I suggest a shorter name:

Suggested change

sealed class TableTopSceneViewInitializationStatus {

sealed class TableTopSceneViewStatus {

toolkit/ar/src/main/java/com/arcgismaps/toolkit/ar/internal/ArSessionWrapper.kt

+ * @since 200.6.0
+ */
+@Composable
+internal fun rememberArSessionWrapper(applicationContext: Context): ArSessionWrapper = remember { ArSessionWrapper(applicationContext) }


gunt0001 · 2024-10-01T14:27:26Z

toolkit/ar/src/main/res/values/strings.xml

+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+    <string name="camera_permission_not_granted">Camera permission not granted</string>
+    <string name="arcore_must_be_installed_to_use_tabletopsceneview_arcore_availability">ARCore must be installed to use TableTopSceneView. ARCore availability: %1$s</string>


As above, name could be shorter? Also we might want to reuse this string for FlyOver as well, so might be better to avoid "TableTopSceneView" in the message.

Suggested change

<string name="arcore_must_be_installed_to_use_tabletopsceneview_arcore_availability">ARCore must be installed to use TableTopSceneView. ARCore availability: %1$s</string>

<string name="arcore_installed_message">ARCore must be installed to use TableTopSceneView. ARCore availability: %1$s</string>

gunt0001

@hud10837 - looks good, a few minor comments/questions.

microapps/ArTabletopApp/app/src/main/java/com/arcgismaps/toolkit/artabletopapp/MainActivity.kt

+                    return
+                }
+            }
+        } catch (e: Exception) {


toolkit/ar/src/main/java/com/arcgismaps/toolkit/ar/TableTopSceneView.kt


 /**
 * Displays a [SceneView] in a tabletop AR environment.
 *
+ * @param requestCameraPermissionAutomatically whether to request the camera permission automatically.
+ * If set to `true`, the camera permission will be requested automatically when the composable is
+ * first displayed. The default value is `true`.


gunt0001 · 2024-10-02T12:28:21Z

...s/ArTabletopApp/app/src/main/java/com/arcgismaps/toolkit/artabletopapp/screens/MainScreen.kt

@@ -45,11 +51,15 @@ fun MainScreen() {
    }
    val tableTopSceneViewProxy = remember { TableTopSceneViewProxy() }
    var tappedLocation by remember { mutableStateOf<Point?>(null) }
+    var initializationStatus: TableTopSceneViewStatus by remember { mutableStateOf(TableTopSceneViewStatus.Initializing) }


It might be convenient to expose a rememberTableTopSceneViewStatus() helper function so users can just call:

Suggested change

var initializationStatus: TableTopSceneViewStatus by remember { mutableStateOf(TableTopSceneViewStatus.Initializing) }

var initializationStatus = rememberTableTopSceneViewStatus()

We can also use this internally.

This wouldn't be the same has remembering a mutable state though. Is there a need for us or for users to remember a non-state version of TableTopSceneViewStatus?

Yes, what I had in mind would be a helper function that remembers mutable state:

@Composable public fun rememberTableTopSceneViewStatus(): MutableState<TableTopSceneViewStatus> = remember { mutableStateOf(TableTopSceneViewStatus.Initializing) }

The user then wouldn't have to worry about initializing the mutable state value with TableTopSceneViewStatus.Initializing

gunt0001 · 2024-10-02T12:30:29Z

toolkit/ar/src/main/java/com/arcgismaps/toolkit/ar/TableTopSceneView.kt

+    var initializationStatus: TableTopSceneViewStatus by remember {
+        mutableStateOf(
+            TableTopSceneViewStatus.Initializing
+        )
+    }


As mentioned above, could use helper function:

Suggested change

var initializationStatus: TableTopSceneViewStatus by remember {

mutableStateOf(

TableTopSceneViewStatus.Initializing

)

}

var initializationStatus = rememberTableTopSceneViewStatus()

gunt0001 · 2024-10-02T12:34:00Z

toolkit/ar/src/main/java/com/arcgismaps/toolkit/ar/TableTopSceneView.kt

+            onInitializationStatusChanged?.invoke(newStatus)
+        }
+    }
+    onInitializationStatusChanged?.invoke(initializationStatus)


For consistency I would make use of updateStatus here:

Suggested change

onInitializationStatusChanged?.invoke(initializationStatus)

updateStatus(TableTopSceneViewStatus.Initializing)

gunt0001 · 2024-10-02T12:35:13Z

toolkit/ar/src/main/java/com/arcgismaps/toolkit/ar/TableTopSceneView.kt

+    val updateStatus = remember {
+        { newStatus: TableTopSceneViewStatus ->
+            initializationStatus = newStatus
+            onInitializationStatusChanged?.invoke(newStatus)


If onInitializationStatusChanged changes during recomposition, will the updated value be used here in the closure? Might be worth to test.

You were absolutely right. I added the callback as a parameter to this function, which fixes the problem.

gunt0001 · 2024-10-02T12:39:04Z

toolkit/ar/src/main/java/com/arcgismaps/toolkit/ar/TableTopSceneView.kt

        }
    }

    Box(modifier = modifier) {
-        ArCameraFeed(arSessionWrapper = arSessionWrapper, onFrame = {}, onTap = {})
+        if (cameraPermissionGranted && arCoreInstalled) {
+            // invoked when the arCoreInstalled state changes to true


Do we need this comment?

Probably not at this point, it seems clear enough what is happening to me

gunt0001 · 2024-10-02T12:40:15Z

toolkit/ar/src/main/java/com/arcgismaps/toolkit/ar/TableTopSceneView.kt

        SceneView(
            arcGISScene = arcGISScene,
            modifier = Modifier.fillMaxSize(),
            onViewpointChangedForCenterAndScale = onViewpointChangedForCenterAndScale,
            onViewpointChangedForBoundingGeometry = onViewpointChangedForBoundingGeometry,
-            graphicsOverlays = graphicsOverlays,
+            graphicsOverlays =
+            graphicsOverlays,


Could this be moved into the line above, i.e. on a single line

gunt0001 · 2024-10-02T12:48:04Z

toolkit/ar/src/main/java/com/arcgismaps/toolkit/ar/TableTopSceneView.kt

+
+    var arCoreInstalled by remember { mutableStateOf(false) }
+
+    // invoked when the cameraPermissionGranted state changes to true


This comment seems out of date? Could be removed?

gunt0001 · 2024-10-02T12:51:09Z

toolkit/ar/src/main/java/com/arcgismaps/toolkit/ar/TableTopSceneViewStatus.kt

+ * Represents the initialization status of a [TableTopSceneView]. The status can be one of the following:
+ * - [Initializing]: The [TableTopSceneView] is initializing. The [TableTopSceneView] is not ready to be used yet.
+ * - [Initialized]: The [TableTopSceneView] is initialized successfully. The [TableTopSceneView] is ready to be used.
+ * - [FailedToInitialize]: The [TableTopSceneView] failed to initialize. The [error] property contains


Instead of these bullet points, better to move this doc directly on the individual enum values.

gunt0001 · 2024-10-03T10:31:43Z

...s/ArTabletopApp/app/src/main/java/com/arcgismaps/toolkit/artabletopapp/screens/MainScreen.kt

@@ -45,11 +51,15 @@ fun MainScreen() {
    }
    val tableTopSceneViewProxy = remember { TableTopSceneViewProxy() }
    var tappedLocation by remember { mutableStateOf<Point?>(null) }
+    var initializationStatus: TableTopSceneViewStatus by remember { mutableStateOf(TableTopSceneViewStatus.Initializing) }


Yes, what I had in mind would be a helper function that remembers mutable state:

@Composable public fun rememberTableTopSceneViewStatus(): MutableState<TableTopSceneViewStatus> = remember { mutableStateOf(TableTopSceneViewStatus.Initializing) }

The user then wouldn't have to worry about initializing the mutable state value with TableTopSceneViewStatus.Initializing

gunt0001 · 2024-10-03T10:53:40Z

toolkit/ar/src/main/java/com/arcgismaps/toolkit/ar/TableTopSceneView.kt

+            initializationStatus = newStatus
+            callback?.invoke(newStatus)
+        }
+    }


Another option, instead of the cached lambda would be an extension function on MutableState<TableTopSceneViewStatus>. Personally I would find that more intuitive, but I will leave it to you, either works.

private fun MutableState<TableTopSceneViewStatus>.update( newStatus: TableTopSceneViewStatus, callback: ((TableTopSceneViewStatus) -> Unit)? ) { this.value = newStatus callback?.invoke(newStatus) }

Then you could call this like that:

var initializationStatus: MutableState<TableTopSceneViewStatus> = remember { mutableStateOf( TableTopSceneViewStatus.Initializing ) } ... initializationStatus.update(TableTopSceneViewStatus.Initializing, onInitializationStatusChanged)

I considered this but wasn't sure if it made much since to extend MutableState. I think what you showed here looks reasonable though so I will make this change

gunt0001 · 2024-10-03T10:55:48Z

toolkit/ar/src/main/java/com/arcgismaps/toolkit/ar/TableTopSceneView.kt

+    var arCoreInstalled by remember { mutableStateOf(false) }
+
+    LaunchedEffect(Unit) {
+        delay(10_000)


Why this delay? Can we remove it?

my bad, that wasn't meant to be checked in

gunt0001 · 2024-10-04T07:23:06Z

microapps/ArTabletopApp/app/src/main/java/com/arcgismaps/toolkit/artabletopapp/MainActivity.kt

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        ArcGISEnvironment.apiKey = ApiKey.create(BuildConfig.API_KEY)
        setContent {
            MicroAppTheme {
-                ArTabletopApp()
+                if (isGooglePlayServicesArInstalled.collectAsState().value) {


It may not make a big difference in this specific case but still good practice to use collectAsStateWithLifecycle:

Suggested change

if (isGooglePlayServicesArInstalled.collectAsState().value) {

if (isGooglePlayServicesArInstalled.collectAsStateWithLifecycle().value) {

Note, you would also need to update the comment above.

gunt0001 · 2024-10-04T07:29:39Z

toolkit/ar/src/main/java/com/arcgismaps/toolkit/ar/TableTopSceneViewStatus.kt

+}
+
+@Composable
+public fun rememberTableTopSceneViewStatus(): MutableState<TableTopSceneViewStatus> = remember {


Missing doc

* mv assets folder to correct location * out of the box permissions request * rename camera permission function * make request permission optional * add initialization status * add availability check * update microapp * extract string resources * rm unnecessary changes * don't use stateflow for microapp * rename string res * rename string resource * don't require camera permission before checking arcore visibility * mv box call * add local function for update status * simplify availability check * rename status * make status constructors internal * use updateState for initial status * mv status doc to member objects * add remaining param doc * fix remaining param doc * add parameter for callback to lambda * revert whitespace in manifest * remove debug delay * add factory rememberTableTopSceneViewStatus * add extension fun to mutable state * add extension fun to mutable state * rename camera feed file * use launchedeffect to ensure initializing status is only sent once * Don't send callback on first status * use side effects for callback * use collectAsStateWithLifecycle * add doc to rememberTableTopSceneViewStatus()

* merge `Feature branches/forms` into v.next (#566) * `Forms`: Add `TextFormElement` (#542) * `Forms`: Add `TextFormElement` tests (#551) * add tests * updated feature form doc * bump sdk version * `Forms` : Add SubTypeFeatureLayer support (#559) * `Forms`: Fix stale `LaunchedEffect`s (#563) * fix stale launched effects * use rememberupdatedstate * update feature form doc (#565) * Remove unnecessary creating the viewmodel in the main activity (#571) * Set up Tabletop AR project (#545) * prototype design options * prototype tabletopSceneView * remove unused implementations * create readme * add tabletopsceneviewproxy * update microapp to use tabletop proxy * add TableTopSceneViewScope * apply Compose gradle plugin * fix warnings * rename microapp * delete tests for microapp * add copyright * fix since years * use swift doc on tabletopsceneview * add proxy doc * add scope doc * fix references in proxy doc * fix references in scope doc * fix references in scope doc * newlines * rm unit test * fix doc and imports * fix doc and imports * revert authentication changes --------- Co-authored-by: Gunther Heppner <gheppner@esri.com> * Hud10837/import render code (#580) * import necessary files for rendering camera feed * copyright * rm obj dependency * make kotlin classes internal * make java classes non-public * centralize logging and tag * add doc links to hello ar * make planerenderer companion internal * Fix texture name * add newline * Tabletop AR: Add ArSurfaceView (#590) * bring in existing implementation of ArSurfaceView * bring in changes to TabletopSceneView and TableTopSceneViewState * pare down changes to just implement ARSurfaceView and add lifecycle management wrappers for AR Session and GlSurfaceView * rm camera controller line * mv call to box * mv ArSessionWrapper to internal * fix since tags * rename ARSurfaceView -> ArCameraFeed * rename localLifecycleOwner -> lifecycleOwner * mv initialization of sceneViewProxy to TableTopSceneViewProxy * Hud10837/session init and permissions (#595) * mv assets folder to correct location * out of the box permissions request * rename camera permission function * make request permission optional * add initialization status * add availability check * update microapp * extract string resources * rm unnecessary changes * don't use stateflow for microapp * rename string res * rename string resource * don't require camera permission before checking arcore visibility * mv box call * add local function for update status * simplify availability check * rename status * make status constructors internal * use updateState for initial status * mv status doc to member objects * add remaining param doc * fix remaining param doc * add parameter for callback to lambda * revert whitespace in manifest * remove debug delay * add factory rememberTableTopSceneViewStatus * add extension fun to mutable state * add extension fun to mutable state * rename camera feed file * use launchedeffect to ensure initializing status is only sent once * Don't send callback on first status * use side effects for callback * use collectAsStateWithLifecycle * add doc to rememberTableTopSceneViewStatus() * add new DetectingPlanes status * create callback and set status for first plane detected * add in scene placement logic * add translation factor, anchor point, clipping distance * rm initial viewpoint on scene * display simple helper text while detecting planes * use string res * use string res for lat lon callout content * enhance microapp with status messages * use better data for microapp * rm debug code * use val instead of var for status * cleanup * use display rotation for lens intrinsics * checkout unexpected files from feature branch * checkout unexpected files from feature branch * add doc to TextWithScrim * use when statements and be exhaustive * mv declarations of cameraController and arCoreAnchor * add doc Pose.transformationMatrix * use when (val status = ... * use explicit api mode * fix build warnings --------- Co-authored-by: Kaushik Meesala <kaushik.pulagara@gmail.com> Co-authored-by: Puneet Prakash <puneet_prakash@esri.com> Co-authored-by: Gunther Heppner <gheppner@esri.com>

* Set up Tabletop AR project (#545) * prototype design options * prototype tabletopSceneView * remove unused implementations * create readme * add tabletopsceneviewproxy * update microapp to use tabletop proxy * add TableTopSceneViewScope * apply Compose gradle plugin * fix warnings * rename microapp * delete tests for microapp * add copyright * fix since years * use swift doc on tabletopsceneview * add proxy doc * add scope doc * fix references in proxy doc * fix references in scope doc * fix references in scope doc * newlines * rm unit test * fix doc and imports * fix doc and imports * revert authentication changes --------- Co-authored-by: Gunther Heppner <gheppner@esri.com> * Hud10837/import render code (#580) * import necessary files for rendering camera feed * copyright * rm obj dependency * make kotlin classes internal * make java classes non-public * centralize logging and tag * add doc links to hello ar * make planerenderer companion internal * Fix texture name * add newline * Tabletop AR: Add ArSurfaceView (#590) * bring in existing implementation of ArSurfaceView * bring in changes to TabletopSceneView and TableTopSceneViewState * pare down changes to just implement ARSurfaceView and add lifecycle management wrappers for AR Session and GlSurfaceView * rm camera controller line * mv call to box * mv ArSessionWrapper to internal * fix since tags * rename ARSurfaceView -> ArCameraFeed * rename localLifecycleOwner -> lifecycleOwner * mv initialization of sceneViewProxy to TableTopSceneViewProxy * Hud10837/session init and permissions (#595) * mv assets folder to correct location * out of the box permissions request * rename camera permission function * make request permission optional * add initialization status * add availability check * update microapp * extract string resources * rm unnecessary changes * don't use stateflow for microapp * rename string res * rename string resource * don't require camera permission before checking arcore visibility * mv box call * add local function for update status * simplify availability check * rename status * make status constructors internal * use updateState for initial status * mv status doc to member objects * add remaining param doc * fix remaining param doc * add parameter for callback to lambda * revert whitespace in manifest * remove debug delay * add factory rememberTableTopSceneViewStatus * add extension fun to mutable state * add extension fun to mutable state * rename camera feed file * use launchedeffect to ensure initializing status is only sent once * Don't send callback on first status * use side effects for callback * use collectAsStateWithLifecycle * add doc to rememberTableTopSceneViewStatus() * Tabletop AR: scene placement (#602) * merge `Feature branches/forms` into v.next (#566) * `Forms`: Add `TextFormElement` (#542) * `Forms`: Add `TextFormElement` tests (#551) * add tests * updated feature form doc * bump sdk version * `Forms` : Add SubTypeFeatureLayer support (#559) * `Forms`: Fix stale `LaunchedEffect`s (#563) * fix stale launched effects * use rememberupdatedstate * update feature form doc (#565) * Remove unnecessary creating the viewmodel in the main activity (#571) * Set up Tabletop AR project (#545) * prototype design options * prototype tabletopSceneView * remove unused implementations * create readme * add tabletopsceneviewproxy * update microapp to use tabletop proxy * add TableTopSceneViewScope * apply Compose gradle plugin * fix warnings * rename microapp * delete tests for microapp * add copyright * fix since years * use swift doc on tabletopsceneview * add proxy doc * add scope doc * fix references in proxy doc * fix references in scope doc * fix references in scope doc * newlines * rm unit test * fix doc and imports * fix doc and imports * revert authentication changes --------- Co-authored-by: Gunther Heppner <gheppner@esri.com> * Hud10837/import render code (#580) * import necessary files for rendering camera feed * copyright * rm obj dependency * make kotlin classes internal * make java classes non-public * centralize logging and tag * add doc links to hello ar * make planerenderer companion internal * Fix texture name * add newline * Tabletop AR: Add ArSurfaceView (#590) * bring in existing implementation of ArSurfaceView * bring in changes to TabletopSceneView and TableTopSceneViewState * pare down changes to just implement ARSurfaceView and add lifecycle management wrappers for AR Session and GlSurfaceView * rm camera controller line * mv call to box * mv ArSessionWrapper to internal * fix since tags * rename ARSurfaceView -> ArCameraFeed * rename localLifecycleOwner -> lifecycleOwner * mv initialization of sceneViewProxy to TableTopSceneViewProxy * Hud10837/session init and permissions (#595) * mv assets folder to correct location * out of the box permissions request * rename camera permission function * make request permission optional * add initialization status * add availability check * update microapp * extract string resources * rm unnecessary changes * don't use stateflow for microapp * rename string res * rename string resource * don't require camera permission before checking arcore visibility * mv box call * add local function for update status * simplify availability check * rename status * make status constructors internal * use updateState for initial status * mv status doc to member objects * add remaining param doc * fix remaining param doc * add parameter for callback to lambda * revert whitespace in manifest * remove debug delay * add factory rememberTableTopSceneViewStatus * add extension fun to mutable state * add extension fun to mutable state * rename camera feed file * use launchedeffect to ensure initializing status is only sent once * Don't send callback on first status * use side effects for callback * use collectAsStateWithLifecycle * add doc to rememberTableTopSceneViewStatus() * add new DetectingPlanes status * create callback and set status for first plane detected * add in scene placement logic * add translation factor, anchor point, clipping distance * rm initial viewpoint on scene * display simple helper text while detecting planes * use string res * use string res for lat lon callout content * enhance microapp with status messages * use better data for microapp * rm debug code * use val instead of var for status * cleanup * use display rotation for lens intrinsics * checkout unexpected files from feature branch * checkout unexpected files from feature branch * add doc to TextWithScrim * use when statements and be exhaustive * mv declarations of cameraController and arCoreAnchor * add doc Pose.transformationMatrix * use when (val status = ... * use explicit api mode * fix build warnings --------- Co-authored-by: Kaushik Meesala <kaushik.pulagara@gmail.com> Co-authored-by: Puneet Prakash <puneet_prakash@esri.com> Co-authored-by: Gunther Heppner <gheppner@esri.com> * TableTop improvements (#607) * stop rendering planes as soon as the anchor point is determined * configure ARCore Session to only detect horizontal planes * disable pan/zoom/rotate interaction * make clippingDistance an optional parameter and ensure modifier is first optional param * enhance comment Co-authored-by: hud10837 <hmiears@esri.com> --------- Co-authored-by: hud10837 <hmiears@esri.com> * TableTop doc (#644) * expand AR readme * explain translationFactor * update micro app to use simplified dataset * cache arcGISSceneAnchor in the composition * add prerequisites and usage sections * doc fixes * add AR to top level readme * remove basemap and make surface opaque * add screenshot * update README * improve doc on TableTopSceneView parameters * add README for ARTableTop micro app * improve doc on translationFactor Co-authored-by: hud10837 <hmiears@esri.com> * refine doc for prerequisites * add snippet for AR required manifest * fix spelling Co-authored-by: hud10837 <hmiears@esri.com> --------- Co-authored-by: hud10837 <hmiears@esri.com> * Tabletop - disable navigation (#662) * remove interaction options from TableTopSceneView * remove setViewpoint functions from TableTopSceneViewProxy * remove unused imports * Tabletop callout fix & Session config (#663) * cache _isManualRenderingEnabled and sync with SceneView when set * invoke content lambda when SceneView ready or in manual rendering mode * configure AR Session in onResume instead of upon construction * change ArCameraFeed constructor to take a Session instead of ArSessionWrapper * create Session in onResume, expose as StateFlow * observe session state flow in order to render the ArCameraFeed * lock the screen of the TableTop micro app * roll back screen orientation lock * sync manual rendering flag in sceneView property setter * remove `onDrawStatusChanged` from TableTopSceneView * fix link * fix link * fix link --------- Co-authored-by: hud10837 <hmiears@esri.com> Co-authored-by: Kaushik Meesala <kaushik.pulagara@gmail.com> Co-authored-by: Puneet Prakash <puneet_prakash@esri.com>

hud10837 added 8 commits September 27, 2024 12:37

mv assets folder to correct location

465da07

out of the box permissions request

38125c4

rename camera permission function

2411007

make request permission optional

d1cc91f

add initialization status

e380525

add availability check

5744da4

update microapp

5f63240

extract string resources

4f2391b

hud10837 commented Oct 1, 2024

View reviewed changes

rm unnecessary changes

587365a

hud10837 marked this pull request as ready for review October 1, 2024 09:53

gunt0001 reviewed Oct 1, 2024

View reviewed changes

gunt0001 assigned hud10837 Oct 1, 2024

gunt0001 self-requested a review October 1, 2024 14:30

hud10837 added 8 commits October 1, 2024 18:50

don't use stateflow for microapp

5500af4

rename string res

7af4e32

rename string resource

43f628f

don't require camera permission before checking arcore visibility

0e2112d

mv box call

16e17b8

add local function for update status

f238926

simplify availability check

8847e01

rename status

1cff26e

gunt0001 reviewed Oct 2, 2024

View reviewed changes

hud10837 added 7 commits October 2, 2024 16:26

make status constructors internal

24f0f6a

use updateState for initial status

cb2743f

mv status doc to member objects

102d6b0

add remaining param doc

3af91f4

fix remaining param doc

6821203

add parameter for callback to lambda

e03e5f4

revert whitespace in manifest

1fdf759

hud10837 requested a review from gunt0001 October 3, 2024 07:26

gunt0001 approved these changes Oct 3, 2024

View reviewed changes

hud10837 added 4 commits October 3, 2024 15:33

remove debug delay

58d4ca8

add factory rememberTableTopSceneViewStatus

9070741

add extension fun to mutable state

079892c

add extension fun to mutable state

af42c1b

gunt0001 reviewed Oct 4, 2024

View reviewed changes

hud10837 added 6 commits October 4, 2024 10:37

rename camera feed file

5363c89

use launchedeffect to ensure initializing status is only sent once

431574a

Don't send callback on first status

33cf809

use side effects for callback

b7dc5a8

use collectAsStateWithLifecycle

4854824

add doc to rememberTableTopSceneViewStatus()

0296641

hud10837 merged commit 447f32f into feature-branches/tabletop-ar Oct 4, 2024

hud10837 deleted the hud10837/session-init-and-permissions branch October 4, 2024 09:08

	<string name="google_play_services_for_ar_must_be_installed_to_run_this_app">Google Play Services for AR must be installed to run this app.</string>
	<string name="arcore_installed_message">Google Play Services for AR must be installed to run this app.</string>

	if (arCoreInstalled) {
	if (arCoreInstalled && cameraPermissionGranted) {

	sealed class TableTopSceneViewInitializationStatus {
	sealed class TableTopSceneViewStatus {

	<string name="arcore_must_be_installed_to_use_tabletopsceneview_arcore_availability">ARCore must be installed to use TableTopSceneView. ARCore availability: %1$s</string>
	<string name="arcore_installed_message">ARCore must be installed to use TableTopSceneView. ARCore availability: %1$s</string>

	var initializationStatus: TableTopSceneViewStatus by remember { mutableStateOf(TableTopSceneViewStatus.Initializing) }
	var initializationStatus = rememberTableTopSceneViewStatus()

	onInitializationStatusChanged?.invoke(initializationStatus)
	updateStatus(TableTopSceneViewStatus.Initializing)


		var arCoreInstalled by remember { mutableStateOf(false) }

		// invoked when the cameraPermissionGranted state changes to true

	if (isGooglePlayServicesArInstalled.collectAsState().value) {
	if (isGooglePlayServicesArInstalled.collectAsStateWithLifecycle().value) {

Hud10837/session init and permissions #595

Hud10837/session init and permissions #595

Conversation

hud10837 commented Sep 30, 2024 • edited Loading

Description:

Summary of changes:

Pre-merge Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment was marked as resolved.

Choose a reason for hiding this comment

gunt0001 left a comment

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hud10837 commented Sep 30, 2024 •

edited

Loading