Depend on daily/dev builds of Maps SDK #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rovided via command line over versions from gradle.properties.
sorenoid
approved these changes
Nov 7, 2024
| ) | ||
| sdkVersionNumber | ||
| } else { | ||
| logger.warn("Maps SDK dependency: $sdkVersionNumber-$sdkBuildNumber") |
There was a problem hiding this comment.
jenkins logged
11:21:57 Maps SDK dependency: 200.6.0-4399
which is the build number in gradle.properties. daily is 4412
TADraeseke
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
LGTM! @sorenoid asked to merge when ready to try to get it in the noon build. SO merging now...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue: https://devtopia.esri.com/runtime/kotlin/issues/4771
Description:
Changes to gradle scripts to depend on the latest MapsSDK version as part of every CI build. For local builds (from Android Studio), the Maps SDK version is still determined from
gradle.properties.Summary of changes:
In
settings.gradle.ktschanged initialization ofsdkVersionNumberandsdkBuildNumberto prioritise versions provided via command line. If these don't exist, fall back to versions ingradle.properties.Pre-merge Checklist