-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] Style point with picture marker symbols #182
Conversation
…rkerSymbols' Conflicts: Shared/Samples/Style point with picture marker symbols/README.md
...Samples/Style point with picture marker symbols/StylePointWithPictureMarkerSymbolsView.swift
Outdated
Show resolved
Hide resolved
...Samples/Style point with picture marker symbols/StylePointWithPictureMarkerSymbolsView.swift
Outdated
Show resolved
Hide resolved
...Samples/Style point with picture marker symbols/StylePointWithPictureMarkerSymbolsView.swift
Outdated
Show resolved
Hide resolved
...Samples/Style point with picture marker symbols/StylePointWithPictureMarkerSymbolsView.swift
Outdated
Show resolved
Hide resolved
...Samples/Style point with picture marker symbols/StylePointWithPictureMarkerSymbolsView.swift
Outdated
Show resolved
Hide resolved
...Samples/Style point with picture marker symbols/StylePointWithPictureMarkerSymbolsView.swift
Outdated
Show resolved
Hide resolved
...Samples/Style point with picture marker symbols/StylePointWithPictureMarkerSymbolsView.swift
Outdated
Show resolved
Hide resolved
…intWithPictureMarkerSymbolsView.swift Co-authored-by: Ting <tchen@esri.com>
…intWithPictureMarkerSymbolsView.swift Co-authored-by: Ting <tchen@esri.com>
…intWithPictureMarkerSymbolsView.swift Co-authored-by: Ting <tchen@esri.com>
…intWithPictureMarkerSymbolsView.swift Co-authored-by: Ting <tchen@esri.com>
…intWithPictureMarkerSymbolsView.swift Co-authored-by: Ting <tchen@esri.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see Phil's comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing this sample! Can you do one more re-indent of the whole file? For some reason the whitespaces aren't consistent in it.
Phil is busy with other stuff so I added Mark to take a look. |
...Samples/Style point with picture marker symbols/StylePointWithPictureMarkerSymbolsView.swift
Show resolved
Hide resolved
...Samples/Style point with picture marker symbols/StylePointWithPictureMarkerSymbolsView.swift
Show resolved
Hide resolved
...Samples/Style point with picture marker symbols/StylePointWithPictureMarkerSymbolsView.swift
Show resolved
Hide resolved
…intWithPictureMarkerSymbolsView.swift Co-authored-by: Mark Dostal <mhdostal@aol.com>
...Samples/Style point with picture marker symbols/StylePointWithPictureMarkerSymbolsView.swift
Outdated
Show resolved
Hide resolved
...Samples/Style point with picture marker symbols/StylePointWithPictureMarkerSymbolsView.swift
Outdated
Show resolved
Hide resolved
…intWithPictureMarkerSymbolsView.swift Co-authored-by: Mark Dostal <mhdostal@aol.com>
…intWithPictureMarkerSymbolsView.swift Co-authored-by: Mark Dostal <mhdostal@aol.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Description
This PR implements
Style point with picture marker symbols
inDisplay information
category.URL to README: https://github.com/Esri/arcgis-maps-sdk-swift-samples/tree/Caleb/New-PictureMarkerSymbols/Shared/Samples/Style%20point%20with%20picture%20marker%20symbols
Linked Issue(s)
swift/issues/4087
How To Test
Screenshots