Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] Add web tiled layer #492

Merged
merged 9 commits into from
Aug 9, 2024
Merged

[New] Add web tiled layer #492

merged 9 commits into from
Aug 9, 2024

Conversation

fcamas
Copy link
Contributor

@fcamas fcamas commented Aug 8, 2024

Description

This PR implements Add web tiled layer in Layers category.
URL to README

Linked Issue(s)

  • swift/issues/

How To Test

Run the sample and a map will appear. As you navigate the map, map tiles will be fetched automatically and displayed on the map.

Screenshots

set-reference-scale

@fcamas fcamas requested a review from pgruenler August 8, 2024 00:24
@fcamas fcamas self-assigned this Aug 8, 2024
Copy link
Contributor

@pgruenler pgruenler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple comments.

@fcamas fcamas marked this pull request as ready for review August 8, 2024 20:38
@fcamas fcamas requested review from CalebRas and pgruenler August 8, 2024 20:39
pgruenler
pgruenler previously approved these changes Aug 8, 2024
Copy link
Contributor

@pgruenler pgruenler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works well, and the preview looks good.

Co-authored-by: Caleb Rasmussen <crasmussen@esri.com>
@fcamas fcamas requested review from CalebRas and pgruenler August 9, 2024 00:12
Copy link
Collaborator

@CalebRas CalebRas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for making those changes, Fredy.

@fcamas fcamas requested a review from CalebRas August 9, 2024 15:10
@fcamas fcamas merged commit b75c958 into main Aug 9, 2024
1 check passed
@fcamas fcamas deleted the Fredy/New-AddWebTiledLayer branch August 9, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants