Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visionOS support to UtilityNetworkTrace #1011

Open
wants to merge 5 commits into
base: v.next
Choose a base branch
from

Conversation

philium
Copy link
Contributor

@philium philium commented Jan 16, 2025

No description provided.

@philium philium self-assigned this Jan 16, 2025
Copy link
Contributor

@zkline101 zkline101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback:

  • This can be removed for visionOS so the button has a default circle around it.

  • In the example file, the UtilityNetworkTrace could use a bit of top padding since it is cramped on the top of the floating panel

  • The "Cancel Starting Point Selection" is a bit of an eye sore and should look like this. Where the background of the button is red and the text is white.
    Screenshot 2025-01-17 at 9 53 53 AM

  • Under "Advanced Options", it isn't clear the "Name" row is selectable to type in text. So adding a hover effect to the TextField there could probably help.

@zkline101
Copy link
Contributor

Also, I was expecting each section to look like it does in iOS:
Simulator Screenshot - iPad Pro 13-inch (M4) - 2025-01-17 at 10 12 39

where there is a background color for each row. Similar to how the settings app is in visionOS or iOS. I'm assuming there is something in the code that is preventing that default behavior on visionOS .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants