Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API Key instructions #772

Merged
merged 9 commits into from
Jul 3, 2024
Merged

Update API Key instructions #772

merged 9 commits into from
Jul 3, 2024

Conversation

dfeinzimer
Copy link
Collaborator

swift/5514

@dfeinzimer dfeinzimer self-assigned this Jun 24, 2024
README.md Outdated Show resolved Hide resolved
@dfeinzimer
Copy link
Collaborator Author

Closing for time being

@dfeinzimer dfeinzimer closed this Jun 24, 2024
Copy link
Contributor

@maryharvey maryharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfeinzimer some feedback. thanks.

Examples/ExamplesApp/ExamplesApp.swift Outdated Show resolved Hide resolved
Examples/ExamplesApp/ExamplesApp.swift Outdated Show resolved Hide resolved
Examples/ExamplesApp/ExamplesApp.swift Outdated Show resolved Hide resolved
Examples/ExamplesApp/ExamplesApp.swift Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@dfeinzimer dfeinzimer reopened this Jun 26, 2024
dfeinzimer and others added 3 commits June 26, 2024 10:59
Co-Authored-By: Mary Harvey <3710427+maryharvey@users.noreply.github.com>
Co-Authored-By: Mary Harvey <3710427+maryharvey@users.noreply.github.com>
@dfeinzimer dfeinzimer changed the title Update API Key Instructions Update API Key instructions Jun 26, 2024
dfeinzimer and others added 4 commits June 26, 2024 11:08
Co-Authored-By: Mary Harvey <3710427+maryharvey@users.noreply.github.com>
Co-Authored-By: Mary Harvey <3710427+maryharvey@users.noreply.github.com>
Co-Authored-By: Mary Harvey <3710427+maryharvey@users.noreply.github.com>
@dfeinzimer dfeinzimer marked this pull request as ready for review June 27, 2024 16:31
mhdostal
mhdostal previously approved these changes Jun 27, 2024
@dfeinzimer
Copy link
Collaborator Author

@maryharvey, any further changes on this you'd like to see?

maryharvey
maryharvey previously approved these changes Jul 3, 2024
Copy link
Contributor

@maryharvey maryharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfeinzimer Looks great and all the links work .. so thanks. One tiny tweak.

README.md Outdated Show resolved Hide resolved
@dfeinzimer dfeinzimer dismissed stale reviews from maryharvey and mhdostal via c2125e5 July 3, 2024 16:27
Co-authored-by: Mary Harvey <mharvey@esri.com>
@dfeinzimer dfeinzimer requested a review from mhdostal July 3, 2024 16:28
@dfeinzimer dfeinzimer merged commit 70ce5e8 into v.next Jul 3, 2024
@dfeinzimer dfeinzimer deleted the swift5514 branch July 3, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants