Merge pull request #600 from Esri/b/group-userlist

fix(portal): searchGroupUsers will now respect additional parameters
Esri · Jul 19, 2019 · 0768eab · 0768eab
2 parents 4de6881 + 79b15b5
commit 0768eab
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/packages/arcgis-rest-portal/src/groups/get.ts b/packages/arcgis-rest-portal/src/groups/get.ts
@@ -107,6 +107,8 @@ export interface ISearchGroupUsersOptions
   name?: string;
   sortField?: string;
   sortOrder?: string;
+  joined?: number | number[];
+  memberType?: string;
   [key: string]: any;
 }
 
@@ -139,7 +141,7 @@ export function searchGroupUsers(
   const url = `${getPortalUrl(searchOptions)}/community/groups/${id}/userlist`;
   const options = appendCustomParams<ISearchGroupUsersOptions>(
     searchOptions,
-    ["name", "num", "start", "sortField", "sortOrder"],
+    ["name", "num", "start", "sortField", "sortOrder", "joined", "memberType"],
     {
       httpMethod: "GET"
     }

diff --git a/packages/arcgis-rest-portal/test/groups/get.test.ts b/packages/arcgis-rest-portal/test/groups/get.test.ts
@@ -113,15 +113,17 @@ describe("groups", () => {
           sortField: "fullname",
           sortOrder: "asc",
           num: 2,
-          start: 2
+          start: 2,
+          joined: [null, 123456],
+          memberType: "member"
         },
         ...MOCK_REQOPTS
       })
         .then(response => {
           expect(fetchMock.called()).toEqual(true);
           const [url, options]: [string, RequestInit] = fetchMock.lastCall("*");
           expect(url).toEqual(
-            "https://myorg.maps.arcgis.com/sharing/rest/community/groups/5bc/userlist?f=json&name=jupe&sortField=fullname&sortOrder=asc&num=2&start=2&token=fake-token"
+            "https://myorg.maps.arcgis.com/sharing/rest/community/groups/5bc/userlist?f=json&name=jupe&sortField=fullname&sortOrder=asc&num=2&start=2&joined=%2C123456&memberType=member&token=fake-token"
           );
           expect(options.method).toBe("GET");
           done();