chore(:bathtub:): bump to tslint-config-standard and resolve new lint…

… errors

AFFECTS PACKAGES:
@esri/arcgis-rest-auth
@esri/arcgis-rest-feature-service-admin
@esri/arcgis-rest-geocoder
@esri/arcgis-rest-request
@esri/arcgis-rest-sharing
@esri/arcgis-rest-users

package.json

@@ -56,7 +56,7 @@
     "ts-node": "^3.3.0",
     "tslint": "^5.11.0",
     "tslint-config-prettier": "^1.6.0",
-    "tslint-config-standard": "^6.0.1",
+    "tslint-config-standard": "^8.0.1",
     "typedoc": "^0.12.0",
     "typescript": "^3.0.0"
   },
@@ -75,7 +75,7 @@
   },
   "scripts": {
     "build": "lerna run build",
-    "test": "npm run test:node && npm run test:chrome",
+    "test": "npm run lint && npm run test:node && npm run test:chrome",
     "test:chrome:debug": "karma start --auto-watch --no-single-run --browsers=Chrome",
     "test:chrome": "karma start --single-run --browsers=Chrome",
     "test:chrome:ci": "karma start --single-run --browsers ChromeHeadlessCI karma.conf.js",

packages/arcgis-rest-auth/src/ApplicationSession.ts

@@ -31,15 +31,15 @@ export interface IApplicationSessionOptions {
    * Expiration date for the `token`
    */
   expires?: Date;
-  
+
   /**
    * URL of ArcGIS REST base, defaults to "https://www.arcgis.com/sharing/rest"
    */
   portal?: string;
 
   /**
    * Duration of requested tokens in minutes. defaults to 7200 (5 days).
-  */
+   */
   duration?: number;
 }
 
@@ -79,7 +79,7 @@ export class ApplicationSession implements IAuthenticationManager {
   }
 
   // url isnt actually read or passed through.
-  getToken(
+  public getToken(
     url: string,
     requestOptions?: ITokenRequestOptions
   ): Promise<string> {
@@ -96,7 +96,7 @@ export class ApplicationSession implements IAuthenticationManager {
     return this._pendingTokenRequest;
   }
 
-  refreshToken(requestOptions?: ITokenRequestOptions): Promise<string> {
+  public refreshToken(requestOptions?: ITokenRequestOptions): Promise<string> {
     const options = {
       params: {
         client_id: this.clientId,
@@ -116,7 +116,7 @@ export class ApplicationSession implements IAuthenticationManager {
     );
   }
 
-  refreshSession() {
+  public refreshSession() {
     return this.refreshToken().then(() => this);
   }
 }