fix(ArcGISRequestError): replace null or empty messages and codes wit…

…h UNKNOWN_ERROR and UNKNOWN_ERR AFFECTS PACKAGES: @esri/arcgis-rest-request
Esri · Aug 23, 2018 · bcea1da · bcea1da
1 parent 9ee1c0c
commit bcea1da
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/packages/arcgis-rest-request/src/utils/ArcGISRequestError.ts b/packages/arcgis-rest-request/src/utils/ArcGISRequestError.ts
@@ -53,12 +53,15 @@ export class ArcGISRequestError {
    * @param options - The original options and parameters of the request
    */
   constructor(
-    message = "UNKNOWN_ERROR",
-    code: string | number = "UNKNOWN_ERROR_CODE",
+    message?: string,
+    code?: string | number,
     response?: any,
     url?: string,
     options?: IRequestOptions
   ) {
+    message = message || "UNKNOWN_ERROR";
+    code = code || "UNKNOWN_ERROR_CODE";
+
     this.name = "ArcGISRequestError";
     this.message =
       code === "UNKNOWN_ERROR_CODE" ? message : `${code}: ${message}`;

diff --git a/packages/arcgis-rest-request/test/utils/ArcGISRequestError.test.ts b/packages/arcgis-rest-request/test/utils/ArcGISRequestError.test.ts
@@ -37,4 +37,12 @@ describe("ArcGISRequestError", () => {
     expect(error.originalMessage).toBe("UNKNOWN_ERROR");
     expect(error.response).toEqual(undefined);
   });
+
+  it("should still format with a null or empty string message or code", () => {
+    const error = new ArcGISRequestError(null, "");
+    expect(error.message).toBe("UNKNOWN_ERROR");
+    expect(error.code).toEqual("UNKNOWN_ERROR_CODE");
+    expect(error.originalMessage).toBe("UNKNOWN_ERROR");
+    expect(error.response).toEqual(undefined);
+  });
 });
diff --git a/packages/arcgis-rest-request/test/utils/check-for-errors.test.ts b/packages/arcgis-rest-request/test/utils/check-for-errors.test.ts
@@ -64,7 +64,7 @@ describe("checkForErrors", () => {
   it("should throw an ArcGISRequestError for an error from the ArcGIS Online Billing Backend with a failure status", () => {
     expect(() => {
       checkForErrors(BillingErrorWithCode200);
-    }).toThrowError(ArcGISRequestError, null);
+    }).toThrowError(ArcGISRequestError, "UNKNOWN_ERROR");
   });
 
   it("should throw an ArcGISRequestError for an error when checking long running tasks in ArcGIS REST API", () => {