Skip to content

Commit

Permalink
refactor: stop reexporting appendCustomParams from feature-service pa…
Browse files Browse the repository at this point in the history
…ckage

AFFECTS PACKAGES:
@esri/arcgis-rest-feature-service
@esri/arcgis-rest-geocoder

BREAKING CHANGE:
appendCustomParams is no longer exported by feature-service package
  • Loading branch information
jgravois committed Apr 11, 2019
1 parent b874132 commit c0852cb
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 10 deletions.
3 changes: 1 addition & 2 deletions packages/arcgis-rest-feature-service/src/add.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ import {
request,
IRequestOptions,
appendCustomParams,
cleanUrl,
warn
cleanUrl
} from "@esri/arcgis-rest-request";
import { IEditFeaturesParams, IEditFeatureResult } from "./helpers";

Expand Down
7 changes: 1 addition & 6 deletions packages/arcgis-rest-feature-service/src/helpers.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
/* Copyright (c) 2017-2018 Environmental Systems Research Institute, Inc.
/* Copyright (c) 2017-2019 Environmental Systems Research Institute, Inc.
* Apache-2.0 */

import { appendCustomParams } from "@esri/arcgis-rest-request";

import {
esriGeometryType,
SpatialRelationship,
Expand Down Expand Up @@ -45,6 +43,3 @@ export interface IEditFeaturesParams {
*/
rollbackOnFailure?: boolean;
}

// this function has been moved into @esri/request. it is re-exported here for backwards compatibility
export { appendCustomParams };
3 changes: 1 addition & 2 deletions packages/arcgis-rest-geocoder/src/geocode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
import {
request,
appendCustomParams,
cleanUrl,
IParams
cleanUrl
} from "@esri/arcgis-rest-request";

import {
Expand Down

0 comments on commit c0852cb

Please sign in to comment.